Hide mobile nav on subpages based on backPath #4695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hariombalhara
changed the title
hariombalhara
changed the title
hariombalhara
commented
Sep 24, 2022
| @@ -66,225 +64,213 @@ const Component = ({ | |||
| const allowedMultipleInstalls = categories.indexOf("calendar") > -1; | |||
|
|
|||
| return ( | |||
| <> | |||
| <div className="px-4 pb-3 pt-8 sm:pt-2 md:px-8 lg:px-0 lg:pt-0"> | |||
There was a problem hiding this comment.
Implemented this code using backPath and heading props supported by Shell.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backPathplus Heading combination of AppStore and other pages.It covers all the cases mentioned here #4398 (comment)
I think we need a back button on mobile as well. It is more important to be there because navigation is gone there.
Edit: Found out that it was supposed to work already, but wasn't working due to a bug. Fixed that bug as well.
This is how the flow would be to explore different apps.
Apps -> App1 -> Logo Click -> Apps -> App2
Apps -> App1 -> Back-> App2
Loom Demo
What does this PR do?
Fixes #4398
Environment:Production
Type of change
How should this be tested?
See loom video