Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor layout fixes #4741

Merged
merged 5 commits into from Sep 28, 2022
Merged

Conversation

PeerRich
Copy link
Member

No description provided.

@vercel
Copy link

vercel bot commented Sep 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal 🔄 Building (Inspect) Sep 28, 2022 at 5:52PM (UTC)

@PeerRich PeerRich changed the title fixed back button, fixed app store detail on mobile minor layout fixes Sep 28, 2022
Comment on lines +780 to +784
<div
className={classNames(
props.backPath ? "relative" : "fixed right-4 bottom-[75px] z-40 ",
"cta mb-4 flex-shrink-0 sm:relative sm:bottom-auto sm:right-auto sm:z-0"
)}>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only fix the CTA area on pages without settings

Comment on lines +121 to 125
<div onClick={() => history.back()}>
<VerticalTabItem
name="Back"
href="/"
href="/."
icon={Icon.FiArrowLeft}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go back vs go back to event-types

packages/ui/v2/core/navigation/tabs/VerticalTabItem.tsx Outdated Show resolved Hide resolved
@PeerRich PeerRich enabled auto-merge (squash) September 28, 2022 17:54
@PeerRich PeerRich requested a review from a team September 28, 2022 17:55
@PeerRich PeerRich merged commit 8478363 into main Sep 28, 2022
@PeerRich PeerRich deleted the 4736-app-store-detail-layout-too-wide-on-mobile branch September 28, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant