/event-types/detail wrong empty screen for workflows #4757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gitstart is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi @PeerRich! Kindly review the PR |
CarinaWolli
requested changes
Sep 30, 2022
There was a problem hiding this comment.
Thank you for your contribution 🙏 I have noticed two things that need some changes:
- It should be aligned with the settings tabs (compare with empty screen of apps, should look the same)
- The empty screen of /workflows also got changed, it should stay as is it is right now. So we want it to look like that:
|
Thank you @CarinaWolli for the review, will make the required changes and get back to you |
Co-authored-by: gitstart <gitstart@gitstart.com> Co-authored-by: gitstart <gitstart@users.noreply.github.com> Co-authored-by: Rafael Toledo <87545086+Toledodev@users.noreply.github.com> Co-authored-by: Matheus Muniz <matheusmuniz100@hotmail.com> Co-authored-by: Matheus Muniz <87545749+matheusmuniz03@users.noreply.github.com> Co-authored-by: Thiago Nascimbeni <tnascimbeni@gmail.com> Co-authored-by: Klinger Matheus <50892465+KlingerMatheus@users.noreply.github.com> Co-authored-by: Nitesh Singh <nitesh.singh@gitstart.dev> Co-authored-by: Grace Nshokano <grace.devolop@gmail.com> Co-authored-by: Olusanya Timothy <48022904+seunexplicit@users.noreply.github.com>
|
Hi @CarinaWolli! PR was updated with the changes, kindly review again |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CarinaWolli
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #4265
Demo
Loom:
https://www.loom.com/share/39b25ddceca045c2a98251bbf8f05cb2
Old Version:
Updated Version:
Environment: Staging(main branch) / Production
Type of change