Cleanup + migrate away from process.browser #5408
Merged
+3
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
JeroenReumkens
approved these changes
Nov 8, 2022
| @@ -7,7 +7,7 @@ type BrowserInfo = { | |||
| }; | |||
|
|
|||
| export const getBrowserInfo = (): Partial<BrowserInfo> => { | |||
| if (!process.browser) { | |||
| if (typeof window === "undefined") { | |||
There was a problem hiding this comment.
Perhaps it might make sense to add a small util isBrowser()? Makes that we have this logic only in one place, and also reads a bit easier. The change from NOT to now strict equals almost threw me off thinking it was reverted 😁
haffla
pushed a commit
to tourlane/cal.com
that referenced
this pull request
Nov 22, 2022
* Cleanup + migrate away from process.browser * Bring back HeadSeo in ui/v2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?