Stops content pushing on windows browsers due to overflow-y #5513
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
sean-brydon
approved these changes
Nov 14, 2022
| @@ -344,7 +344,7 @@ export default function SettingsLayout({ | |||
| SettingsSidebarContainer={ | |||
| <div | |||
| className={classNames( | |||
| "fixed inset-y-0 z-50 m-0 h-screen transform overflow-y-scroll border-gray-100 bg-gray-50 transition duration-200 ease-in-out", | |||
| "fixed inset-y-0 z-50 m-0 h-screen w-56 transform overflow-x-hidden overflow-y-scroll border-gray-100 bg-gray-50 transition duration-200 ease-in-out", | |||
There was a problem hiding this comment.
Providing explicit width same as the parent ensures that it isn't pushed around due to overflow-y scrollbar. But it adds a horizontal scrollbar which is hidden using the overflow-x-hidden class
hariombalhara
approved these changes
Nov 14, 2022
alishaz-polymath
added
♻️ autoupdate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Stops content pushing when vertical scrollbar shows up on some windows browsers
Fixes #5383
Loom Video
Environment: Staging(main branch)
Type of change
Checklist