Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Intl.DateTimeFormat logic to determine locale. #5519

Conversation

emrysal
Copy link
Contributor

@emrysal emrysal commented Nov 14, 2022

I believe in ChromeHeadless window.navigator.language === "": this is throwing errors.

image

(Shared IP in screenshot is AWS, not PII)

@vercel
Copy link

vercel bot commented Nov 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Nov 14, 2022 at 7:44PM (UTC)

Copy link
Contributor

@leog leog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice tweak!

@emrysal emrysal merged commit f822177 into main Nov 14, 2022
@emrysal emrysal deleted the bugfix/RangeError-Incorrect-locale-information-provided-ChromeHeadless branch November 14, 2022 19:46
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants