fix: ui of button #5552
Merged
fix: ui of button #5552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alannnc
reviewed
Nov 17, 2022
| </Button> | ||
| <div className="mt-4 flex w-full items-center gap-4 self-start text-sm font-medium"> | ||
| {props.actionText && ( | ||
| <button className="text-sm font-medium leading-4" onClick={() => props.onAction}> |
There was a problem hiding this comment.
is there a reason why we changed Button for button?
There was a problem hiding this comment.
left one is what the ui we want. Button in /components has py and px and background change on hover which we don't want so it would require over ridding a lot of styles if we use Button or should i just add another variant prop and use Button ?
alannnc
reviewed
Nov 17, 2022
alannnc
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5548
