Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed wrong calculation of duration type on event type page. #5557

Merged
merged 1 commit into from Nov 17, 2022
Merged

Fixed wrong calculation of duration type on event type page. #5557

merged 1 commit into from Nov 17, 2022

Conversation

JeroenReumkens
Copy link
Contributor

What does this PR do?

Calculation of the event type duration was not correct, eg 90 mins was converted into a very big number of hours.

Environment: Staging(main branch)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Go to an event type page, go to the advanced tab, fill in a number of minutes (eg 300). Save it, and see that after a refresh we've converted into the correct amount of hours or days. It will only show it as hours / days when it rounds to a full amount of hours / days. No decimals. If it does not round, we still show minutes.

@vercel
Copy link

vercel bot commented Nov 17, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Nov 17, 2022 at 7:50AM (UTC)

@hariombalhara hariombalhara merged commit a8186e3 into main Nov 17, 2022
@hariombalhara hariombalhara deleted the hotfix/fix-conversion-of-duration-type branch November 17, 2022 08:08
@JeroenReumkens JeroenReumkens restored the hotfix/fix-conversion-of-duration-type branch November 17, 2022 08:21
@emrysal emrysal deleted the hotfix/fix-conversion-of-duration-type branch November 17, 2022 13:06
@JeroenReumkens
Copy link
Contributor Author

Fixes #5555

@JeroenReumkens JeroenReumkens mentioned this pull request Nov 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hariombalhara hariombalhara hariombalhara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JeroenReumkens @hariombalhara