Fix/event type clone #5659
Merged
Fix/event type clone #5659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alannnc
commented
Nov 23, 2022
| @@ -360,7 +360,8 @@ export const eventTypesRouter = router({ | |||
| }; | |||
|
|
|||
| const appKeys = await getAppKeysFromSlug("daily-video"); | |||
| if (typeof appKeys.api_key === "string") { | |||
| // Shouldn't override input locations | |||
| if (rest.locations?.length === 0 && typeof appKeys.api_key === "string") { | |||
There was a problem hiding this comment.
When creating new locations are empty array []
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow up from PR #5540
When duplicating event type, input locations shouldn't be override by default location in event type create trpc.
Fixes #5504
Environment: Staging(main branch) / Production
Type of change
Checklist