MS Teams use joinWebUrl from response body
#5886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zomars
approved these changes
Dec 7, 2022
joeauyeung
added a commit
that referenced
this pull request
Dec 8, 2022
* Add joinWebUrl to event * Remove console.log Co-authored-by: alannnc <alannnc@gmail.com>
3 tasks
This was referenced Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR changes where we retrieve the MS Teams join URL from the response body. Before we were checking for the presence of
joinUrl. Reading through forums and the docs sometimesjoinUrlmay not be present. In the docs for theonlineMeetingresourcejoinUrlis not defined butjoinWebUrlis. When creating a Teams link bothjoinUrlandjoinWebUrlare the same.https://learn.microsoft.com/en-us/graph/api/resources/onlineMeeting?view=graph-rest-1.0#properties
Fixes # (issue)
Environment: Staging(main branch) / Production
Type of change
How should this be tested?
Checklist