-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing GCal emailing notif and sequential deleting #6460
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
i think some scheduling serivces still send the notification if I am not incorrect |
This is just to let Google know it shouldn't send notifications for the deleted events through the API, like when we delete all remaining events from a series, because we already send a notification from Cal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think is good enough. But is it possible to suppress notifications only in recurring events? |
@zomars wouldn't we want to also avoid notifications for single events too? Cal already sends a notification for those too |
I don't know, hence the question. But merging for now. 🙏🏽 |
What does this PR do?
Making sure Google Calendar does not send deleted events notifications when deleted by API, as we handle the notification for them. Also, Google Calendar delete was causing problems when using its API in parallel, changing it to be sequential.
Environment: Staging(main branch) / Production
Type of change
How should this be tested?
Try to cancel a recurring event with lots of instances and you shouldn't see Google sending cancelled notification for each instance nor a 500 error when doing so.