Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing GCal emailing notif and sequential deleting #6460

Merged
merged 2 commits into from
Jan 13, 2023

Conversation

leog
Copy link
Contributor

@leog leog commented Jan 13, 2023

What does this PR do?

Making sure Google Calendar does not send deleted events notifications when deleted by API, as we handle the notification for them. Also, Google Calendar delete was causing problems when using its API in parallel, changing it to be sequential.

Environment: Staging(main branch) / Production

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

Try to cancel a recurring event with lots of instances and you shouldn't see Google sending cancelled notification for each instance nor a 500 error when doing so.

@leog leog requested a review from a team January 13, 2023 12:26
@vercel
Copy link

vercel bot commented Jan 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Jan 13, 2023 at 2:33PM (UTC)

@PeerRich
Copy link
Member

i think some scheduling serivces still send the notification if I am not incorrect

@leog
Copy link
Contributor Author

leog commented Jan 13, 2023

i think some scheduling serivces still send the notification if I am not incorrect

This is just to let Google know it shouldn't send notifications for the deleted events through the API, like when we delete all remaining events from a series, because we already send a notification from Cal.

Copy link
Member

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zomars
Copy link
Member

zomars commented Jan 13, 2023

I think is good enough. But is it possible to suppress notifications only in recurring events?

@leog
Copy link
Contributor Author

leog commented Jan 13, 2023

I think is good enough. But is it possible to suppress notifications only in recurring events?

@zomars wouldn't we want to also avoid notifications for single events too? Cal already sends a notification for those too

@zomars
Copy link
Member

zomars commented Jan 13, 2023

I think is good enough. But is it possible to suppress notifications only in recurring events?

@zomars wouldn't we want to also avoid notifications for single events too? Cal already sends a notification for those too

I don't know, hence the question. But merging for now. 🙏🏽

@zomars zomars merged commit a4d6f7d into main Jan 13, 2023
@zomars zomars deleted the fix/google-calendar-emails-seq-delete branch January 13, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants