Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable email input if new user invited to team #6471

Merged
merged 2 commits into from
Jan 14, 2023

Conversation

joeauyeung
Copy link
Contributor

What does this PR do?

This PR prevents the email input on the signup page if a new user is invited to a team. This is to prevent any bugs in the future.

New user
image

Normal signup page
image

Fixes # (issue)

Environment: Staging(main branch) / Production

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Invite a new user to a team
  • When accepting the invite the email input should be disabled
  • Visit CAL_URL/signup
    • You should be able to input an email

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't performed a self-review of my own code and corrected any misspellings
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@vercel
Copy link

vercel bot commented Jan 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Jan 14, 2023 at 0:04AM (UTC)

@PeerRich
Copy link
Member

nice!

@PeerRich PeerRich enabled auto-merge (squash) January 13, 2023 23:56
@zomars zomars merged commit a1fc4ec into main Jan 14, 2023
@zomars zomars deleted the team-invite-signup-disable-email-input branch January 14, 2023 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants