Fix: modal content hidden

[G3root]

What does this PR do?

before:

after:
https://www.loom.com/share/1d69040b06e944f1824e4ddbb5ce205c

Environment: Staging(main branch) / Production

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Chore (refactoring code, technical debt, workflow improvements)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How should this be tested?

• Test A
• Test B

Checklist

• I haven't read the contributing guide
• My code doesn't follow the style guidelines of this project
• I haven't performed a self-review of my own code and corrected any misspellings
• I haven't commented my code, particularly in hard-to-understand areas
• I haven't checked if my PR needs changes to the documentation
• I haven't checked if my changes generate no new warnings
• I haven't added tests that prove my fix is effective or that my feature works
• I haven't checked if new and existing unit tests pass locally with my changes

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
cal	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Jan 16, 2023 at 3:36PM (UTC)

[PeerRich]

we need to thoroughly test this because I feel like we touched this file so many times and it always regressed somewhere else

[emrysal]

Of course this is an edge case, but let's make sure the overflow works for all dialogs (even for insanely vertically excessive viewports)

Tested Mobile & Desktop larger dialogs, looking good so far

[G3root]

@emrysal great findings, something i'm gonna look into my future PR's ❤️. pushed some changes to fix those edge cases.

[emrysal]

Agree with the change, I don't believe allowScroll would ever have a need to be set to false.

[Udit-takkar]

@emrysal @G3root allowScroll prop is required to prevent this from happening

[Udit-takkar]

still unable to fix this react-select dropdown without allowScroll . tried few things from here JedWatson/react-select#4088 , JedWatson/react-select#4150

[G3root]

@Udit-takkar sorry my bad, I should've checked that. i can do a follow up reintroducing the allowScroll prop .

[PeerRich]

@Udit-takkar sorry my bad, I should've checked that. i can do a follow up reintroducing the allowScroll prop .

@G3root should we open a new PR before we merge to production today?

[Udit-takkar]

@G3root no issue it's more of a react-select bug on a dialog.