Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/insights #6511

Merged
merged 60 commits into from Mar 23, 2023
Merged

/insights #6511

merged 60 commits into from Mar 23, 2023

Conversation

PeerRich
Copy link
Member

@PeerRich PeerRich commented Jan 16, 2023 •
edited by alannnc

CleanShot 2023-01-16 at 16 40 07@2x

Update:
image

@linear
Copy link

linear bot commented Jan 16, 2023

CAL-803 /analytics

figma: https://www.figma.com/file/ZJNAFHCAq6rnuGRgUFxjzQ/Cal.com-Teams?node-id=514%3A80787&t=h4kM3EyGKfIPY9o8-4

@vercel
Copy link

vercel bot commented Jan 16, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
cal ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 23, 2023 at 10:07PM (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 23, 2023 at 10:07PM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
cal-com-storybook ⬜️ Ignored (Inspect) Mar 23, 2023 at 10:07PM (UTC)

@PeerRich PeerRich linked an issue Jan 16, 2023 that may be closed by this pull request
[CAL-803] /insights #6507
Closed
@PeerRich PeerRich marked this pull request as draft January 16, 2023 15:40
PeerRich
PeerRich commented Jan 16, 2023
View reviewed changes
apps/web/pages/_app.tsx Outdated
@@ -1,3 +1,4 @@
import "@tremor/react/dist/esm/tremor.css";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we want to fork this CSS file and apply our own styling

@socket-security
Copy link

socket-security bot commented Feb 12, 2023 •
edited

New dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request report summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

zomars
zomars requested changes Mar 23, 2023
View reviewed changes
Copy link
Member

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking to make some improvements 🙏🏽

@zomars
Copy link
Member

zomars commented Mar 23, 2023

I see we use "analytics" and "insights" interchangeably. I propose we stick to "insights" everywhere.

@PeerRich
Copy link
Member Author

I see we use "analytics" and "insights" interchangeably. I propose we stick to "insights" everywhere.

agree! Insights everywhere

zomars
zomars approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Moved most of the code to features/insights
  • Renamed all analytics to insights
  • Extracted InsightsProvider
  • Extracted trpc router
  • Type fixes

zomars
zomars reviewed Mar 23, 2023
View reviewed changes
packages/features/insights/context/FiltersProvider.tsx
import { FilterProvider } from "./provider";

export function FiltersProvider({ children }: { children: React.ReactNode }) {
// TODO: Sync insight filters with URL parameters
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non blocking but should be made in a follow up

@zomars zomars mentioned this pull request Mar 23, 2023
Merged
@kodiakhq kodiakhq bot merged commit cfa720a into main Mar 23, 2023
18 of 19 checks passed
@kodiakhq kodiakhq bot deleted the 6507-cal-803-analytics branch March 23, 2023 22:10
@PeerRich
Copy link
Member Author

oh shit, not sure if this should merge this quickly

@alishaz-polymath alishaz-polymath added the docs area: docs, documentation, cal.com/docs label Apr 18, 2023
@alishaz-polymath alishaz-polymath removed the docs area: docs, documentation, cal.com/docs label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zomars zomars zomars approved these changes

@alannnc alannnc alannnc left review comments

@sean-brydon sean-brydon sean-brydon left review comments

@hariombalhara hariombalhara Awaiting requested review from hariombalhara

Assignees

@alannnc alannnc

@sean-brydon sean-brydon

Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CAL-803] /insights
6 participants
@PeerRich @zomars @alannnc @sean-brydon @leog @alishaz-polymath