New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate SSG Page used as cache for user's third-party calendar #6775
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
@roae is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very clever approach. cc @emrysal can you take a look given a chance?
is this related to the RFC for caching calendars or is this unrelated? |
It is a different approach @PeerRich no need for a custom caldav server (at least not yet) |
@roae can you uncommit your yarn.lock? (take it from our main) |
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpicks. Will test properly on Monday
Co-authored-by: Omar López <zomars@me.com>
Co-authored-by: Omar López <zomars@me.com>
Co-authored-by: Omar López <zomars@me.com>
* Cache fixes * Testing * SWR breaks embed tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HOLY SHIT 4s down to 240ms?! |
Of course it varies between calls but still pretty impressive 🙌🏽 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unfortunately there is a new skeleton loader that wasnt there on current prod
CleanShot.2023-02-10.at.22.28.19.mp4
Adding more context to this change. We discovered that if a slot got taken and refetched it didn't disappear in the UI due the use of our local state. But agreed that we can improve the UX to match the previous one. |
I'm like 70% sure you can return from an API endpoint in Next with infinite cache times and not have to do the empty page hack - I do this all the time - |
8b074b0
to
5da47dd
Compare
Care to elaborate @t3dotgg ? Is this cache useful for every user or would it only work per browser/request? |
Skeleton got fixed |
Merging for now. We can always follow up with further improvements. Talked to @roae and it seems like the next big thing to solve would be reducing bundle size. |
nice lets merge! should I or do you wanna click the magic green button |
whopsy wrong button clicky |
I searched the current main. There are a few cases where the entire lodash is being imported for no reason. Should be a very easy fix that instantly reduces bundle size. |
i think we can get rid of lodash alltogether no? most of lodash is ECMA specs now anyway |
What does this PR do?
TODO
Fixes #4535
/claim #4535
Note: On development environment the response time of getSchedule endpoint increases because NextJS compiles the cache page first. To notice the improvement you must run a production build.
Type of change
Checklist