Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check app-store types on CI #7190

Merged
merged 4 commits into from Mar 2, 2023
Merged

Check app-store types on CI #7190

merged 4 commits into from Mar 2, 2023

Conversation

hariombalhara
Copy link
Member

@hariombalhara hariombalhara commented Feb 18, 2023

Adds "type-check" script to package.json so that type check for app-store runs on CI. Also, fixes the issues found.

Fixes #7189

@vercel
Copy link

vercel bot commented Feb 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
cal ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 2, 2023 at 6:48PM (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 2, 2023 at 6:48PM (UTC)

@@ -13,3 +13,5 @@ jest.mock("@calcom/lib/crypto", () => ({
"userApiKey": "test"
}`,
}));

export {};
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make it work with --isolatedModules flag

@@ -18,8 +18,6 @@
"../types/*.d.ts",
"../types/next-auth.d.ts",
"**/*.ts",
"**/*.tsx",
"../../apps/web/server/**/*.ts",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't needed and also not recommended to directly import from apps/web

@hariombalhara hariombalhara requested a review from a team February 18, 2023 08:46
@github-actions
Copy link
Contributor

github-actions bot commented Feb 18, 2023

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 212.71 KB (-1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/[user]/book 185.5 KB 398.22 KB 113.78% (+/- <0.01%)
/apps/[slug]/[...pages] 388.73 KB 601.44 KB 171.84% (+/- <0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@hariombalhara hariombalhara marked this pull request as draft February 19, 2023 07:39
@deploysentinel
Copy link

deploysentinel bot commented Mar 2, 2023

Current Playwright Test Results Summary

✅ 49 Passing - ❌ 1 Failing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 03/02/2023 06:56:30pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 080bb23

Started: 03/02/2023 06:52:50pm UTC

❌ Failures

📄   apps/web/playwright/event-types.e2e.ts • 1 Failure

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests user can add multiple organizer address
Initial Attempt
Error: Test timeout of 60000ms exceeded.
Test timeout of 60000ms exceeded.
50% (1) 1 / 2 run
failed over last 7 days
0% (0) 0 / 2 runs
flaked over last 7 days

View Detailed Build Results


@zomars zomars merged commit e12b21a into main Mar 2, 2023
@zomars zomars deleted the type-safety-app-store branch March 2, 2023 18:58
dmkav pushed a commit to join-com/cal-com that referenced this pull request Mar 6, 2023
* Check app-store types on CI

* Fix ESLINt error
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-1109] Add type-check for app-store
3 participants