Removed some of the UTC logic which shouldn't be there #7425
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -50,7 +48,7 @@ const DateOverrideList = ({ | |||
| day: "numeric", | |||
| }).format(item.ranges[0].start)} | |||
| </h3> | |||
| {item.ranges[0].end.getUTCHours() === 0 && item.ranges[0].end.getUTCMinutes() === 0 ? ( | |||
| {item.ranges[0].end.getHours() === 0 && item.ranges[0].end.getMinutes() === 0 ? ( | |||
There was a problem hiding this comment.
getHours/getMinutes being 0-0 is only possible during an all-day event.
|
It shows 7:00 PM - 7:00 PM now for me 🤔 |
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! Fifty-two Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
I can save date overrides for march 1st and 2nd (my date/time when saving was march 1st at 11PM GMT-5). It is saved successfully in the database however the date overrides don't show up in the list. That's why: - new Date() is utc so it is already march 2nd - override.date has always timestamp 00:00 so it is also smaller than the utc time which was in my case 2023-03-02T04:00
|
No failed tests 🎉 |
* Removed some of the UTC logic which shouldn't be there * Upgrade rhf, remove SSR on [schedule] page * Fix potential bug with date * Amend schedule trpc call & don't show edit availability if id is undefined * type fix * Order date overrides in list by date * Changed logic to check for unavailable * Fix bug report spotted by @CarinaWolli I can save date overrides for march 1st and 2nd (my date/time when saving was march 1st at 11PM GMT-5). It is saved successfully in the database however the date overrides don't show up in the list. That's why: - new Date() is utc so it is already march 2nd - override.date has always timestamp 00:00 so it is also smaller than the utc time which was in my case 2023-03-02T04:00 * Actual fix, gotta remember it's the schedule tz
What does this PR do?
Fixes 11:00 - 11:00 All Day date override display issue.