Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor for event type description #7450

Merged
merged 16 commits into from Mar 2, 2023
Merged

Conversation

CarinaWolli
Copy link
Member

What does this PR do?

Adds editor to event type description.

  • New lines
    • in /event-types it is shown without the new lines
  • Hyperlinks
    • Currently, the dialog to create a new event type does not have the link option in the toolbar because I couldn't make the portal for the link work within the dialog. But links are still formated as links, see screenshot create event-type modal
  • Bold
  • Italic

Fixes #5764

event type settings

Screenshot 2023-03-01 at 09 16 22

create event-type modal

Screenshot 2023-03-01 at 08 58 44

/event-types

Screenshot 2023-03-01 at 08 47 53

/[username]

Screenshot 2023-03-01 at 09 00 38

booking page

Screenshot 2023-03-01 at 09 00 13

Environment: Staging(main branch) / Production

Type of change

  • New feature (non-breaking change which adds functionality)

@CarinaWolli CarinaWolli requested a review from a team March 1, 2023 14:23
@CarinaWolli CarinaWolli requested a review from zomars as a code owner March 1, 2023 14:23
@CarinaWolli CarinaWolli requested a review from a team March 1, 2023 14:23
@vercel
Copy link

vercel bot commented Mar 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
cal ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 2, 2023 at 7:10PM (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 2, 2023 at 7:10PM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 212.72 KB (🟡 +10 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Eighteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/[user]/[type] 98 KB 310.72 KB 88.78% (+/- <0.01%)
/[user]/[type]/embed 98.03 KB 310.75 KB 88.79% (+/- <0.01%)
/[user]/book 185.53 KB 398.25 KB 113.79% (+/- <0.01%)
/apps/[slug]/[...pages] 388.73 KB 601.46 KB 171.84% (🟡 +0.01%)
/d/[link]/[slug] 97.65 KB 310.37 KB 88.68% (+/- <0.01%)
/d/[link]/[slug]/embed 97.68 KB 310.4 KB 88.69% (+/- <0.01%)
/d/[link]/book 185.18 KB 397.9 KB 113.69% (+/- <0.01%)
/event-types 347.3 KB 560.02 KB 160.01% (🔴 +31.20%)
/event-types/[type] 379.73 KB 592.46 KB 169.27% (🔴 +31.08%)
/getting-started/[[...step]] 328.57 KB 541.29 KB 154.65% (🟡 +0.01%)
/settings/my-account/profile 433.95 KB 646.67 KB 184.76% (🟡 +0.01%)
/settings/teams/[id]/profile 268.92 KB 481.64 KB 137.61% (🟡 +0.01%)
/team/[slug] 113.05 KB 325.77 KB 93.08% (🟡 +0.01%)
/team/[slug]/[type] 97.65 KB 310.37 KB 88.68% (🟡 +0.01%)
/team/[slug]/[type]/embed 97.68 KB 310.4 KB 88.69% (+/- <0.01%)
/team/[slug]/book 185.19 KB 397.91 KB 113.69% (🟡 +0.01%)
/team/[slug]/embed 113.12 KB 325.84 KB 93.10% (🟡 +0.01%)
/workflows/[workflow] 292.68 KB 505.4 KB 144.40% (🟡 +0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link
Member

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it

@zomars zomars merged commit cfb625e into main Mar 2, 2023
@zomars zomars deleted the feat/editor-event-type-description branch March 2, 2023 19:55
dmkav pushed a commit to join-com/cal-com that referenced this pull request Mar 6, 2023
* add editor for event type description

* enable same things for markdownIt

* show links in blue

* fix placeholder design

* format description for event list

* limit event descript ot 4 lines in list

* shorten event-type description whenever needed

* add editor to create event type dialog

* fix link title in event type list

* Fix overwriting users column when saving event types (calcom#7445)

* Only overwrite user column when present

* Clean up

* Merge branch 'main' into feat/editor-event-type-description

* Merge branch 'main' into feat/editor-event-type-description

# Conflicts:
#	apps/web/pages/settings/my-account/profile.tsx

* Linting

---------

Co-authored-by: CarinaWolli <wollencarina@gmail.com>
Co-authored-by: Joe Au-Yeung <65426560+joeauyeung@users.noreply.github.com>
Co-authored-by: zomars <zomars@me.com>
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-490] Allow hyperlinks in descriptions?
4 participants