Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new error for no available user #7609

Merged
merged 6 commits into from
Mar 9, 2023
+16 −4
Merged

new error for no available user #7609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bbb53f1
new error for no available user
PeerRich Mar 8, 2023
474ca22
Merge branch 'main' into 7608-cal-1205-better-issue-for-no-available-…
PeerRich Mar 8, 2023
93a44cb
Merge branch 'main' into 7608-cal-1205-better-issue-for-no-available-…
PeerRich Mar 9, 2023
e84fc4a
Merge branch 'main' into 7608-cal-1205-better-issue-for-no-available-…
PeerRich Mar 9, 2023
e4a1b5d
Added cursor-pointer & extra whitespace before 'go back.'
emrysal Mar 9, 2023
864e917
Merge branch 'main' into 7608-cal-1205-better-issue-for-no-available-…
PeerRich Mar 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions apps/web/components/booking/pages/BookingPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,17 +615,28 @@ export default BookingPage;
function ErrorMessage({ error }: { error: unknown }) {
const { t } = useLocale();
const { query: { rescheduleUid } = {} } = useRouter();
const router = useRouter();

return (
<div data-testid="booking-fail" className="mt-2 border-l-4 border-yellow-400 bg-yellow-50 p-4">
<div data-testid="booking-fail" className="mt-2 border-l-4 border-blue-400 bg-blue-50 p-4">
<div className="flex">
<div className="flex-shrink-0">
<FiAlertTriangle className="h-5 w-5 text-yellow-400" aria-hidden="true" />
<FiAlertTriangle className="h-5 w-5 text-blue-400" aria-hidden="true" />
</div>
<div className="ltr:ml-3 rtl:mr-3">
<p className="text-sm text-yellow-700">
<p className="text-sm text-blue-700">
{rescheduleUid ? t("reschedule_fail") : t("booking_fail")}{" "}
{error instanceof HttpError || error instanceof Error ? t(error.message) : "Unknown error"}
{error instanceof HttpError || error instanceof Error ? (
<>
{t("can_you_try_again")}{" "}
<span className="cursor-pointer underline" onClick={() => router.back()}>
{t("go_back")}
</span>
.
</> /* t(error.message) */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"No available users found" is not the only possible error message, we definitely need a way to differentiate the error thrown (Like error code?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the question is, do we want to show the error there. i dont think so. we need to log the error yes, but ideally we should show a generic error that is helpful (go back) vs a very technical error

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll handle it on the backend.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use error codes? Like E1001 = "The user was not available at this slot" and so on...

) : (
"Unknown error"
)}
</p>
</div>
</div>
Expand Down
1 change: 1 addition & 0 deletions apps/web/public/static/locales/en/common.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1640,6 +1640,7 @@
"app_is_connected": "{{dependencyName}} is connected",
"requires_app": "Requires {{dependencyName}}",
"verification_code": "Verification code",
"can_you_try_again": "Can you try again with a different time?",
"verify": "Verify",
"select_all": "Select All",
"default_conferencing_bulk_title": "Bulk update existing event types",
Expand Down