Fixes formatted description in email #7696
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! Nineteen Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
Current Playwright Test Results Summary✅ 66 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 03/23/2023 11:59:54am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: d5ebcd6 Started: 03/23/2023 11:52:01am UTC
|
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Routing Link - Reporting and CSV Download
Retry 1 • Initial Attempt |
2.81% (5)5 / 178 runsfailed over last 7 days |
25.28% (45)45 / 178 runsflaked over last 7 days |
|
Routing Forms Seeded Routing Form Router URL should work
Retry 2 • Retry 1 • Initial Attempt |
0.56% (1)1 / 179 runfailed over last 7 days |
7.26% (13)13 / 179 runsflaked over last 7 days |
|
converted to draft as some more adjustments are needed lists in email need to be fixed: |
Socket Security Pull Request ReportDependency issues detected: If you merge this pull request, you will not be alerted to the instances of these issues again. 📜 Install scriptsInstall scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts. Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.
🫣 Native codeContains native code which could be a vector to obscure malicious code, and generally decrease the likelihood of reproducible or reliable installs. Ensure that native code bindings are expected. Consumers may consider pure JS and functionally similar alternatives to avoid the challenges and risks associated with native code bindings.
Pull request report summary
Bot CommandsTo ignore an alert, reply with a comment starting with
Powered by socket.dev |
|
Thank you for our review @hariombalhara 🙏 I implemented your feedback and bundle size looks good now as well |
| @@ -67,6 +67,7 @@ | |||
| "accept-language-parser": "^1.5.0", | |||
| "async": "^3.2.4", | |||
| "bcryptjs": "^2.4.3", | |||
| "canvas": "^2.11.0", | |||
There was a problem hiding this comment.
It doesn't seem to be used.
| "canvas": "^2.11.0", |
There was a problem hiding this comment.
Not sure why, but without canvas, it was throwing an error. I think it is required with jsdom
…places, we can do away with ts-ignore and get type safety
| @@ -0,0 +1,21 @@ | |||
| import DOMPurify from "dompurify"; | |||
There was a problem hiding this comment.
I think we can remove this duplicate by call markdownAndSanitize in tRPC calls and avoiding to do it on client side.
|
Calendar Invite still has the similar problem as email. It shows markdown, we can fix that in a followup. |
|
I think it needs @zomars approval as a code owner before it can be merged |
|
@CarinaWolli It needs review from UI team which would be @sean-brydon @PeerRich or @baileypumfleet |
What does this PR do?
Adds formatting to event-type description in email:
Fixes #7686
Type of change