Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timezone select - create two variants #7875

Merged
merged 5 commits into from Mar 26, 2023
Merged

Fix timezone select - create two variants #7875

merged 5 commits into from Mar 26, 2023

Conversation

sean-brydon
Copy link
Member

@sean-brydon sean-brydon commented Mar 22, 2023

CleanShot 2023-03-22 at 14 30 27@2x

CleanShot 2023-03-22 at 14 46 35@2x

CleanShot 2023-03-22 at 14 46 45@2x


Fixed: changes
CleanShot 2023-03-25 at 13 52 19@2x
CleanShot 2023-03-25 at 13 53 55@2x

@sean-brydon sean-brydon requested review from a team March 22, 2023 06:49
@vercel
Copy link

vercel bot commented Mar 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
cal ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 25, 2023 at 6:16AM (UTC)
inkblot ❌ Failed (Inspect) Mar 25, 2023 at 6:16AM (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 25, 2023 at 6:16AM (UTC)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate

@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2023

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 233.22 KB (-10 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/availability/[schedule] 271.96 KB 505.18 KB 144.34% (🟡 +0.02%)
/bookings/[status] 272.27 KB 505.48 KB 144.42% (+/- <0.01%)
/getting-started/[[...step]] 303 KB 536.21 KB 153.20% (🟡 +0.03%)
/settings/my-account/general 266.3 KB 499.51 KB 142.72% (🟡 +0.02%)
/settings/teams/[id]/members 297.02 KB 530.23 KB 151.49% (🟡 +0.03%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@deploysentinel
Copy link

deploysentinel bot commented Mar 22, 2023

Current Playwright Test Results Summary

✅ 66 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 03/25/2023 06:26:44am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 0b559d2

Started: 03/25/2023 06:21:31am UTC

⚠️ Flakes

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests user can add multiple organizer address
Retry 1Initial Attempt
4.62% (9) 9 / 195 runs
failed over last 7 days
33.33% (65) 65 / 195 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-03-24 at 11 36 19 PM

Few minor issues that needs to be fixed

  1. In light mode the text color of timezone select is darker than the above text( Cal Video, 30 minutes)
  2. can you increase the width of the dropdown component?

Copy link
Contributor

@roae roae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@emrysal emrysal dismissed Udit-takkar’s stale review March 26, 2023 19:18

Feedback implemented

Copy link
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved :)

@emrysal emrysal merged commit 04c634e into main Mar 26, 2023
20 checks passed
@emrysal emrysal deleted the bug/timezone-select branch March 26, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants