Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detailed error logs to handleNewBooking #7907

Merged
merged 2 commits into from
Mar 23, 2023
Merged

Add detailed error logs to handleNewBooking #7907

merged 2 commits into from
Mar 23, 2023

Conversation

roae
Copy link
Contributor

@roae roae commented Mar 23, 2023

What does this PR do?

The objective is to have more details when the error "No available users found." occurs and to know if it is by time zone and daylight saving time.

@roae roae requested a review from zomars as a code owner March 23, 2023 17:23
@roae roae requested a review from a team March 23, 2023 17:23
@vercel
Copy link

vercel bot commented Mar 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
cal ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 23, 2023 at 5:46PM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
ui ⬜️ Ignored (Inspect) Visit Preview Mar 23, 2023 at 5:46PM (UTC)

@@ -143,6 +143,9 @@ const isWithinAvailableHours = (
return true;
}
}
log.error(
`NAUF: isWithinAvailableHours ${JSON.stringify({ ...timeSlot, organizerTimeZone, workingHours })}`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NAUF = No Available Users Found helps to query logs

@github-actions
Copy link
Contributor

github-actions bot commented Mar 23, 2023

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 210.9 KB (🟡 +1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Twenty-one Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/[user] 111.34 KB 322.24 KB 92.07% (🟡 +9.50%)
/[user]/[type] 99.83 KB 310.73 KB 88.78% (+/- <0.01%)
/[user]/[type]/embed 99.85 KB 310.75 KB 88.79% (+/- <0.01%)
/[user]/book 191.24 KB 402.14 KB 114.90% (+/- <0.01%)
/[user]/embed 111.41 KB 322.31 KB 92.09% (🟡 +9.50%)
/booking/[uid] 131.43 KB 342.33 KB 97.81% (+/- <0.01%)
/d/[link]/[slug] 99.47 KB 310.37 KB 88.68% (+/- <0.01%)
/d/[link]/[slug]/embed 99.5 KB 310.4 KB 88.69% (+/- <0.01%)
/d/[link]/book 190.89 KB 401.79 KB 114.80% (+/- <0.01%)
/event-types 354.03 KB 564.93 KB 161.41% (🟢 -0.03%)
/event-types/[type] 386.74 KB 597.63 KB 170.75% (🟡 +0.02%)
/getting-started/[[...step]] 334.19 KB 545.09 KB 155.74% (🟡 +0.01%)
/settings/my-account/calendars 195.58 KB 406.48 KB 116.14% (+/- <0.01%)
/settings/my-account/profile 429.11 KB 640.01 KB 182.86% (🟡 +0.01%)
/settings/teams/[id]/profile 273.66 KB 484.56 KB 138.45% (🟢 -0.03%)
/team/[slug] 113.88 KB 324.78 KB 92.80% (🟡 +9.50%)
/team/[slug]/[type] 99.48 KB 310.38 KB 88.68% (+/- <0.01%)
/team/[slug]/[type]/embed 99.51 KB 310.41 KB 88.69% (+/- <0.01%)
/team/[slug]/book 190.89 KB 401.79 KB 114.80% (+/- <0.01%)
/team/[slug]/embed 113.95 KB 324.85 KB 92.81% (🟡 +9.51%)
/workflows/[workflow] 298.77 KB 509.67 KB 145.62% (🟢 -0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending minor nit lgtm

@deploysentinel
Copy link

Current Playwright Test Results Summary

✅ 52 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 03/23/2023 05:57:36pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 495463a

Started: 03/23/2023 05:52:22pm UTC

⚠️ Flakes

📄   apps/web/playwright/embed-code-generator.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Embed Code Generator Tests Event Type Edit Page open Embed Dialog for the Event Type
Retry 1Initial Attempt
3.85% (9) 9 / 234 runs
failed over last 7 days
16.24% (38) 38 / 234 runs
flaked over last 7 days

📄   apps/web/playwright/availability.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Availablity tests Date Overrides
Retry 2Retry 1Initial Attempt
0% (0) 0 / 241 runs
failed over last 7 days
6.22% (15) 15 / 241 runs
flaked over last 7 days

View Detailed Build Results


@emrysal emrysal merged commit 1cdc97d into main Mar 23, 2023
@emrysal emrysal deleted the roae/error-logs branch March 23, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants