Delete rescheduled booking #7910
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
|
||
| //delete orignal rescheduled booking (no seats event) | ||
| if (!eventType.seatsPerTimeSlot) { | ||
| await prisma.booking.delete({ |
There was a problem hiding this comment.
We used to delete the booking in the eventManger.reschedule function. This got changed in #5427 to handle seated events differently, but we forgot to delete nomal rescheduled events
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 Three Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
Current Playwright Test Results Summary✅ 66 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 03/27/2023 09:08:05am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: ec4baa0 Started: 03/27/2023 09:03:11am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests user can add multiple organizer address
Retry 1 • Initial Attempt |
4.40% (8)8 / 182 runsfailed over last 7 days |
32.42% (59)59 / 182 runsflaked over last 7 days |
There was a problem hiding this comment.
@CarinaWolli, thanks for finding the missing code. I adjusted the tests to the new behaviour and just have a question.
…com/calcom/cal.com into fix/rescheduled-booking-not-deleted
| expect(newBooking).not.toBeNull(); | ||
| expect(rescheduledBooking).toBeNull(); |
There was a problem hiding this comment.
@emrysal Test for my fix. Fails before and succeeds now
| @@ -26,7 +26,11 @@ test.describe("Onboarding", () => { | |||
| await page.locator("input[name=username]").fill("new user onboarding"); | |||
| await page.locator("input[name=name]").fill("new user 2"); | |||
| await page.locator("input[role=combobox]").click(); | |||
| await page.locator("text=Europe/London GMT +0:00").click(); | |||
There was a problem hiding this comment.
London is now in timezone GMT +1 because of dst
What does this PR do?
Fixes that rescheduled bookings are not deleted anymore for non seat events.
Also fixes the number of available seats shown on BookingPage. It was taking the number of available seats of the booking that was rescheduled and not of the new slot the users wants to book.
Type of change
How should this be tested?