Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: AppStore CLI Create command not working after upgrading to yarn 3 #7975

Merged
merged 2 commits into from
Mar 28, 2023

Conversation

hariombalhara
Copy link
Member

@hariombalhara hariombalhara commented Mar 28, 2023

What does this PR do?

Fixes

  • Failing yarn create-app command. Reported here image
  • Also removes stale README.md from template

Environment: Production

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Run yarn create-app and notice that it was failing earlier and now it passes.

@hariombalhara hariombalhara requested review from a team March 28, 2023 10:05
@vercel
Copy link

vercel bot commented Mar 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
cal ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 28, 2023 at 10:15AM (UTC)
dhe ❌ Failed (Inspect) Mar 28, 2023 at 10:15AM (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 28, 2023 at 10:15AM (UTC)

Copy link
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 233.26 KB (🟡 +18 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Fifty-eight Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/[user] 103.4 KB 336.66 KB 96.19% (🟡 +9.50%)
/[user]/[type] 91.85 KB 325.11 KB 92.89% (+/- <0.01%)
/[user]/[type]/embed 91.88 KB 325.14 KB 92.90% (+/- <0.01%)
/[user]/book 183.45 KB 416.71 KB 119.06% (+/- <0.01%)
/[user]/embed 103.47 KB 336.72 KB 96.21% (🟡 +9.50%)
/apps 167.18 KB 400.43 KB 114.41% (+/- <0.01%)
/apps/[slug] 190.9 KB 424.15 KB 121.19% (+/- <0.01%)
/apps/[slug]/[...pages] 392.31 KB 625.56 KB 178.73% (🟡 +0.01%)
/apps/categories 152.07 KB 385.33 KB 110.09% (🟡 +0.01%)
/apps/categories/[category] 155.94 KB 389.2 KB 111.20% (+/- <0.01%)
/apps/installed/[category] 197.05 KB 430.3 KB 122.94% (+/- <0.01%)
/availability 155.38 KB 388.64 KB 111.04% (+/- <0.01%)
/availability/[schedule] 272.14 KB 505.4 KB 144.40% (+/- <0.01%)
/availability/troubleshoot 152.76 KB 386.02 KB 110.29% (+/- <0.01%)
/booking/[uid] 123.57 KB 356.83 KB 101.95% (+/- <0.01%)
/bookings/[status] 272.38 KB 505.64 KB 144.47% (+/- <0.01%)
/d/[link]/[slug] 91.5 KB 324.76 KB 92.79% (+/- <0.01%)
/d/[link]/[slug]/embed 91.53 KB 324.79 KB 92.80% (+/- <0.01%)
/d/[link]/book 183.11 KB 416.36 KB 118.96% (+/- <0.01%)
/event-types 349.31 KB 582.57 KB 166.45% (🟡 +0.02%)
/event-types/[type] 382.89 KB 616.15 KB 176.04% (🟡 +0.02%)
/getting-started/[[...step]] 303.04 KB 536.3 KB 153.23% (🟡 +0.02%)
/insights 386.24 KB 619.5 KB 177.00% (+/- <0.01%)
/more 151.7 KB 384.96 KB 109.99% (+/- <0.01%)
/settings/admin 157.16 KB 390.41 KB 111.55% (+/- <0.01%)
/settings/admin/apps 165.84 KB 399.1 KB 114.03% (+/- <0.01%)
/settings/admin/apps/[category] 165.83 KB 399.08 KB 114.02% (+/- <0.01%)
/settings/admin/flags 160.05 KB 393.31 KB 112.37% (+/- <0.01%)
/settings/admin/impersonation 157.44 KB 390.7 KB 111.63% (+/- <0.01%)
/settings/billing 157.27 KB 390.52 KB 111.58% (+/- <0.01%)
/settings/developer/api-keys 186.42 KB 419.68 KB 119.91% (+/- <0.01%)
/settings/developer/webhooks 159.76 KB 393.02 KB 112.29% (+/- <0.01%)
/settings/developer/webhooks/[id] 190.61 KB 423.87 KB 121.11% (+/- <0.01%)
/settings/developer/webhooks/new 190.47 KB 423.73 KB 121.07% (+/- <0.01%)
/settings/my-account/appearance 171.23 KB 404.49 KB 115.57% (+/- <0.01%)
/settings/my-account/calendars 191.46 KB 424.71 KB 121.35% (+/- <0.01%)
/settings/my-account/conferencing 163.03 KB 396.29 KB 113.22% (+/- <0.01%)
/settings/my-account/general 266.42 KB 499.68 KB 142.77% (+/- <0.01%)
/settings/my-account/profile 274.32 KB 507.57 KB 145.02% (🟡 +0.02%)
/settings/security/impersonation 159.31 KB 392.56 KB 112.16% (+/- <0.01%)
/settings/security/password 192.6 KB 425.86 KB 121.67% (+/- <0.01%)
/settings/security/sso 167 KB 400.26 KB 114.36% (+/- <0.01%)
/settings/security/two-factor-auth 161.76 KB 395.02 KB 112.86% (+/- <0.01%)
/settings/teams 156.9 KB 390.16 KB 111.47% (+/- <0.01%)
/settings/teams/[id]/appearance 171.25 KB 404.51 KB 115.57% (+/- <0.01%)
/settings/teams/[id]/billing 157.14 KB 390.39 KB 111.54% (+/- <0.01%)
/settings/teams/[id]/members 297.14 KB 530.4 KB 151.54% (+/- <0.01%)
/settings/teams/[id]/profile 269.53 KB 502.78 KB 143.65% (🟡 +0.02%)
/settings/teams/[id]/sso 167.09 KB 400.35 KB 114.39% (+/- <0.01%)
/settings/teams/new 92.72 KB 325.98 KB 93.14% (+/- <0.01%)
/team/[slug] 105.87 KB 339.13 KB 96.89% (🟡 +9.51%)
/team/[slug]/[type] 91.5 KB 324.76 KB 92.79% (+/- <0.01%)
/team/[slug]/[type]/embed 91.54 KB 324.79 KB 92.80% (+/- <0.01%)
/team/[slug]/book 183.11 KB 416.37 KB 118.96% (+/- <0.01%)
/team/[slug]/embed 105.94 KB 339.2 KB 96.91% (🟡 +9.51%)
/teams 151.92 KB 385.17 KB 110.05% (+/- <0.01%)
/workflows 164.81 KB 398.07 KB 113.73% (+/- <0.01%)
/workflows/[workflow] 294.01 KB 527.27 KB 150.65% (🟢 -0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@deploysentinel
Copy link

Current Playwright Test Results Summary

✅ 60 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 03/28/2023 10:25:17am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 1d1f867

Started: 03/28/2023 10:20:22am UTC

⚠️ Flakes

📄   apps/web/playwright/embed-code-generator.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Embed Code Generator Tests Event Type Edit Page open Embed Dialog for the Event Type
Retry 1Initial Attempt
2.65% (5) 5 / 189 runs
failed over last 7 days
20.63% (39) 39 / 189 runs
flaked over last 7 days

View Detailed Build Results


@emrysal emrysal merged commit 736cd63 into main Mar 28, 2023
19 checks passed
@emrysal emrysal deleted the fix/app-store branch March 28, 2023 10:25
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge core area: core, team members only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants