Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing edge case where team is paid but needs to be updated #7988

Merged
merged 2 commits into from
Mar 28, 2023

Conversation

zomars
Copy link
Member

@zomars zomars commented Mar 28, 2023

What does this PR do?

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Make new team with x amount of members
  • Pay it / publish it
  • Try to add/remove members
  • Subscription should update accordingly

@zomars zomars requested a review from a team March 28, 2023 18:15
@vercel
Copy link

vercel bot commented Mar 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
cal ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 28, 2023 at 6:37PM (UTC)
dhe ❌ Failed (Inspect) Mar 28, 2023 at 6:37PM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
ui ⬜️ Ignored (Inspect) Visit Preview Mar 28, 2023 at 6:37PM (UTC)

@zomars zomars added ♻️ autoupdate tells kodiak to keep this branch up-to-date automerge High priority Created by Linear-GitHub Sync labels Mar 28, 2023
Copy link
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops.

@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 233.32 KB (-1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

@deploysentinel
Copy link

Current Playwright Test Results Summary

✅ 52 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 03/28/2023 06:44:36pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: a513809

Started: 03/28/2023 06:39:48pm UTC

⚠️ Flakes

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests user can add multiple organizer address
Retry 1Initial Attempt
2.22% (4) 4 / 180 runs
failed over last 7 days
30% (54) 54 / 180 runs
flaked over last 7 days

View Detailed Build Results


@PeerRich PeerRich merged commit 6e856b3 into main Mar 28, 2023
@PeerRich PeerRich deleted the fix/team-billing-update branch March 28, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge ♻️ autoupdate tells kodiak to keep this branch up-to-date High priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants