Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply labels from linked issues to a PR #8069

Merged
merged 18 commits into from
Apr 4, 2023
Merged

Apply labels from linked issues to a PR #8069

merged 18 commits into from
Apr 4, 2023

Conversation

tedspare
Copy link
Contributor

@tedspare tedspare commented Apr 3, 2023

What does this PR do?

  • When a PR is opened, apply the labels from any linked issue(s)

Fixes # (issue)

Environment: Staging(main branch)

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)

How should this be tested?

  • Open a PR with a linked issue by including "Closes #X" where X is an issue (or by using the Development section at the bottom-right of the PR creation UI). See this PR for example.
    • Ensure the "Apply issue labels to PR" Workflow runs
    • Ensure the labels on the issue are applied to the PR

Checklist

  • My code doesn't follow the style guidelines of this project
    • To work around issues with Yarn Workspaces, I avoided all external dependencies (which meant using Node.js's native HTTP library)
    • Types are missing because the Workflow environment seems to expect plain JavaScript

@tedspare tedspare requested a review from a team April 3, 2023 17:45
@vercel
Copy link

vercel bot commented Apr 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2023 9:20am
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2023 9:20am
web ❌ Failed (Inspect) Apr 4, 2023 9:20am

@vercel
Copy link

vercel bot commented Apr 3, 2023

@tedspare is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 233.33 KB (🟡 +1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Sixty-three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/404 8.45 KB 241.78 KB 69.08% (+/- <0.01%)
/[user] 70.33 KB 303.66 KB 86.76% (+/- <0.01%)
/[user]/[type] 92.07 KB 325.4 KB 92.97% (+/- <0.01%)
/[user]/[type]/embed 92.09 KB 325.42 KB 92.98% (+/- <0.01%)
/[user]/embed 70.39 KB 303.72 KB 86.78% (+/- <0.01%)
/apps 165.54 KB 398.87 KB 113.96% (+/- <0.01%)
/apps/[slug] 187.18 KB 420.51 KB 120.15% (+/- <0.01%)
/apps/[slug]/[...pages] 391.06 KB 624.39 KB 178.40% (+/- <0.01%)
/apps/categories 148.36 KB 381.69 KB 109.05% (+/- <0.01%)
/apps/categories/[category] 152.22 KB 385.55 KB 110.16% (+/- <0.01%)
/apps/installed/[category] 195.57 KB 428.9 KB 122.54% (+/- <0.01%)
/auth/error 19.24 KB 252.57 KB 72.16% (+/- <0.01%)
/auth/forgot-password 25.63 KB 258.96 KB 73.99% (+/- <0.01%)
/auth/forgot-password/[id] 32.83 KB 266.16 KB 76.05% (+/- <0.01%)
/auth/login 40.1 KB 273.43 KB 78.12% (+/- <0.01%)
/auth/logout 7.56 KB 240.89 KB 68.83% (+/- <0.01%)
/availability 153.86 KB 387.19 KB 110.63% (+/- <0.01%)
/availability/[schedule] 268.42 KB 501.75 KB 143.36% (+/- <0.01%)
/availability/troubleshoot 149.04 KB 382.38 KB 109.25% (+/- <0.01%)
/booking/[uid] 123.3 KB 356.63 KB 101.90% (+/- <0.01%)
/bookings/[status] 271.92 KB 505.25 KB 144.36% (+/- <0.01%)
/d/[link]/[slug] 91.72 KB 325.05 KB 92.87% (+/- <0.01%)
/d/[link]/[slug]/embed 91.75 KB 325.08 KB 92.88% (+/- <0.01%)
/event-types 348.27 KB 581.6 KB 166.17% (+/- <0.01%)
/event-types/[type] 381.42 KB 614.75 KB 175.64% (+/- <0.01%)
/insights 383.51 KB 616.84 KB 176.24% (+/- <0.01%)
/more 147.98 KB 381.31 KB 108.95% (+/- <0.01%)
/settings/admin 153.44 KB 386.77 KB 110.50% (+/- <0.01%)
/settings/admin/apps 164.25 KB 397.58 KB 113.60% (+/- <0.01%)
/settings/admin/apps/[category] 164.24 KB 397.57 KB 113.59% (+/- <0.01%)
/settings/admin/flags 156.32 KB 389.65 KB 111.33% (+/- <0.01%)
/settings/admin/impersonation 153.72 KB 387.05 KB 110.59% (+/- <0.01%)
/settings/billing 153.55 KB 386.88 KB 110.54% (+/- <0.01%)
/settings/developer/api-keys 182.7 KB 416.03 KB 118.86% (🟡 +0.01%)
/settings/developer/webhooks 156.2 KB 389.53 KB 111.29% (+/- <0.01%)
/settings/developer/webhooks/[id] 186.89 KB 420.22 KB 120.06% (+/- <0.01%)
/settings/developer/webhooks/new 186.75 KB 420.08 KB 120.02% (+/- <0.01%)
/settings/my-account/appearance 168.01 KB 401.34 KB 114.67% (+/- <0.01%)
/settings/my-account/calendars 187.73 KB 421.06 KB 120.30% (+/- <0.01%)
/settings/my-account/conferencing 159.19 KB 392.52 KB 112.15% (+/- <0.01%)
/settings/my-account/general 262.7 KB 496.03 KB 141.72% (+/- <0.01%)
/settings/my-account/profile 271.24 KB 504.57 KB 144.16% (+/- <0.01%)
/settings/security/impersonation 155.59 KB 388.92 KB 111.12% (+/- <0.01%)
/settings/security/password 191.04 KB 424.37 KB 121.25% (+/- <0.01%)
/settings/security/sso 163.28 KB 396.61 KB 113.32% (+/- <0.01%)
/settings/security/two-factor-auth 158.1 KB 391.43 KB 111.84% (+/- <0.01%)
/settings/teams 153.18 KB 386.51 KB 110.43% (+/- <0.01%)
/settings/teams/[id]/appearance 168.04 KB 401.37 KB 114.68% (+/- <0.01%)
/settings/teams/[id]/billing 153.42 KB 386.75 KB 110.50% (+/- <0.01%)
/settings/teams/[id]/members 294.26 KB 527.59 KB 150.74% (+/- <0.01%)
/settings/teams/[id]/profile 265.88 KB 499.21 KB 142.63% (+/- <0.01%)
/settings/teams/[id]/sso 163.37 KB 396.7 KB 113.34% (+/- <0.01%)
/signup 25.5 KB 258.83 KB 73.95% (+/- <0.01%)
/team/[slug] 72.62 KB 305.95 KB 87.41% (🟡 +0.01%)
/team/[slug]/[type] 91.72 KB 325.05 KB 92.87% (+/- <0.01%)
/team/[slug]/[type]/embed 91.75 KB 325.08 KB 92.88% (+/- <0.01%)
/team/[slug]/embed 72.69 KB 306.02 KB 87.43% (+/- <0.01%)
/teams 148.2 KB 381.53 KB 109.01% (+/- <0.01%)
/video/meeting-ended/[uid] 14.67 KB 248 KB 70.86% (+/- <0.01%)
/video/meeting-not-started/[uid] 14.3 KB 247.63 KB 70.75% (+/- <0.01%)
/video/no-meeting-found 6.6 KB 239.93 KB 68.55% (+/- <0.01%)
/workflows 161.2 KB 394.53 KB 112.72% (+/- <0.01%)
/workflows/[workflow] 290.95 KB 524.28 KB 149.79% (🟡 +0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@PeerRich
Copy link
Member

PeerRich commented Apr 4, 2023

if you open a branch from within an issue it links it to the PR too. will this work too?
CleanShot 2023-04-04 at 11 07 35@2x

@PeerRich PeerRich enabled auto-merge (squash) April 4, 2023 09:08
@PeerRich PeerRich merged commit bb547a0 into calcom:main Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants