Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAL-1545] replace heroicons with lucide.dev #8599

Merged
merged 16 commits into from May 17, 2023
Merged

[CAL-1545] replace heroicons with lucide.dev #8599

merged 16 commits into from May 17, 2023

Conversation

gitstart-calcom
Copy link
Contributor

@gitstart-calcom gitstart-calcom commented May 1, 2023

Fixes #8423

Before

Screenshot 2023-05-12 at 2 29 41 PM

Screenshot 2023-05-12 at 2 52 08 PM
Screenshot 2023-05-12 at 2 52 55 PM
Screenshot 2023-05-12 at 2 54 52 PM
Screenshot 2023-05-12 at 2 55 04 PM
Screenshot 2023-05-12 at 2 55 39 PM
Screenshot 2023-05-12 at 2 59 14 PM
Screenshot 2023-05-12 at 2 59 38 PM
Screenshot 2023-05-12 at 3 00 02 PM
Screenshot 2023-05-12 at 3 00 20 PM
image
image
image

After

Screenshot 2023-05-12 at 1 10 16 PM
Screenshot 2023-05-12 at 1 11 49 PM
Screenshot 2023-05-12 at 1 13 01 PM
Screenshot 2023-05-12 at 1 19 22 PM
Screenshot 2023-05-12 at 1 19 44 PM
Screenshot 2023-05-12 at 1 20 15 PM
Screenshot 2023-05-12 at 1 20 33 PM
Screenshot 2023-05-16 at 12 12 17 PM
image
image
image
image

@linear
Copy link

linear bot commented May 1, 2023

CAL-1545 replace heroicons with lucide.dev

we are now using lucide.dev in calcom/icons and we should get rid of heroicons altogether:

gitstart-calcom one thing to keep in mind is that the default sizes of lucide.dev icons may be different than the default sizes of heroicons, which means you may need to add className="w-4 h-4" or similar to the lucide.dev icons when removing hero icons.

for this PR, can you take screenshots of before and after for every icon?

@vercel
Copy link

vercel bot commented May 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2023 7:26am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
ui ⬜️ Ignored (Inspect) Visit Preview May 17, 2023 7:26am

@socket-security
Copy link

socket-security bot commented May 1, 2023

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

⬆️ Updated Package Version Diff Added Capability Access +/- Transitive Count Publisher
lucide-react@0.171.0 0.130.1...0.171.0 None +0/-0 ericfennis

🚮 Removed packages: @heroicons/react@1.0.6

@gitstart-calcom gitstart-calcom changed the title CALCOM-8423 - [CAL-1545] replace heroicons with lucide.dev [CAL-1545] replace heroicons with lucide.dev May 1, 2023
@github-actions github-actions bot added the ✨ feature New feature or request label May 1, 2023
@gitstart-calcom gitstart-calcom marked this pull request as ready for review May 2, 2023 09:16
@gitstart-calcom gitstart-calcom requested a review from a team May 2, 2023 09:16
@gitstart-calcom gitstart-calcom requested a review from a team May 2, 2023 09:16
@PeerRich
Copy link
Member

PeerRich commented May 5, 2023

CleanShot 2023-05-05 at 22 07 01@2x
@gitstart-calcom

@deploysentinel
Copy link

deploysentinel bot commented May 10, 2023

Current Playwright Test Results Summary

✅ 112 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/17/2023 07:41:50am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 54d8587

Started: 05/17/2023 07:31:45am UTC

⚠️ Flakes

📄   apps/web/playwright/managed-event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Managed Event Types tests Can create managed event type
Retry 1Initial Attempt
1.74% (5) 5 / 288 runs
failed over last 7 days
24.65% (71) 71 / 288 runs
flaked over last 7 days

📄   apps/web/playwright/embed-code-generator.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Embed Code Generator Tests Event Type Edit Page open Embed Dialog for the Event Type
Retry 1Initial Attempt
5.78% (17) 17 / 294 runs
failed over last 7 days
29.93% (88) 88 / 294 runs
flaked over last 7 days

📄   apps/web/playwright/booking-seats.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking with Seats -- new-booker Reschedule for booking with seats -- old-booker Should reschedule booking with seats and if everyone rescheduled it should be deleted
Retry 1Initial Attempt
0% (0) 0 / 298 runs
failed over last 7 days
82.21% (245) 245 / 298 runs
flaked over last 7 days

View Detailed Build Results


@gitstart-calcom
Copy link
Contributor Author

Hi @PeerRich, the failing tests have been fixed now

@keithwillcode keithwillcode added this pull request to the merge queue May 11, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch May 11, 2023
@PeerRich
Copy link
Member

still failing @gitstart-calcom

@gitstart-calcom
Copy link
Contributor Author

still failing @gitstart-calcom

It's failing because the new changes from the main branch have heroicons. We have fixed this on our end and will push the changes along with the before and after screenshots.

@keithwillcode keithwillcode added this pull request to the merge queue May 17, 2023
Merged via the queue into main with commit cfd1a72 May 17, 2023
20 checks passed
@keithwillcode keithwillcode deleted the CALCOM-8423 branch May 17, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-1545] replace heroicons with lucide.dev
6 participants