New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CAL-1545] replace heroicons with lucide.dev #8599
Conversation
CAL-1545 replace heroicons with lucide.dev
we are now using lucide.dev in calcom/icons and we should get rid of heroicons altogether: gitstart-calcom one thing to keep in mind is that the default sizes of lucide.dev icons may be different than the default sizes of heroicons, which means you may need to add className="w-4 h-4" or similar to the lucide.dev icons when removing hero icons. for this PR, can you take screenshots of before and after for every icon? |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
📊 Modified Dependency Overview:
🚮 Removed packages: @heroicons/react@1.0.6 |
Current Playwright Test Results Summary✅ 112 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 05/17/2023 07:41:50am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 54d8587 Started: 05/17/2023 07:31:45am UTC
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Managed Event Types tests Can create managed event type
Retry 1 • Initial Attempt |
1.74% (5)5 / 288 runsfailed over last 7 days |
24.65% (71)71 / 288 runsflaked over last 7 days |
📄 apps/web/playwright/embed-code-generator.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Embed Code Generator Tests Event Type Edit Page open Embed Dialog for the Event Type
Retry 1 • Initial Attempt |
5.78% (17)17 / 294 runsfailed over last 7 days |
29.93% (88)88 / 294 runsflaked over last 7 days |
📄 apps/web/playwright/booking-seats.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Booking with Seats -- new-booker Reschedule for booking with seats -- old-booker Should reschedule booking with seats and if everyone rescheduled it should be deleted
Retry 1 • Initial Attempt |
0% (0)0 / 298 runsfailed over last 7 days |
82.21% (245)245 / 298 runsflaked over last 7 days |
Hi @PeerRich, the failing tests have been fixed now |
still failing @gitstart-calcom |
It's failing because the new changes from the main branch have heroicons. We have fixed this on our end and will push the changes along with the before and after screenshots. |
Fixes #8423
Before
After