Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue#8601: fix #8713

Merged
merged 3 commits into from May 17, 2023
Merged

issue#8601: fix #8713

merged 3 commits into from May 17, 2023

Conversation

utkarsh2310
Copy link
Contributor

@utkarsh2310 utkarsh2310 commented May 5, 2023

What does this PR do?

Removed throw error. Previously updateEvent is not getting called when externalId is undefined. Now it is fixed.

Fixes #8601

Environment: Staging(main branch) / Production

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)

Checklist

  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@vercel
Copy link

vercel bot commented May 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2023 0:56am
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2023 0:56am

@vercel
Copy link

vercel bot commented May 5, 2023

@utkarsh2310 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Member

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution 🙏

@kodiakhq
Copy link
Contributor

kodiakhq bot commented May 16, 2023

This PR could not be merged because the GitHub API returned an internal server error. To enable Kodiak on this pull request please remove the kodiak:disabled label.

When the GitHub API returns an internal server error (HTTP status code 500), it is not safe for Kodiak to retry merging.

For more information please see https://kodiakhq.com/docs/troubleshooting#merge-errors

If you need help, you can open a GitHub issue, check the docs, or reach us privately at support@kodiakhq.com.

docs | dashboard | support

@keithwillcode keithwillcode added this pull request to the merge queue May 17, 2023
Merged via the queue into calcom:main with commit 1f51199 May 17, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge ♻️ autoupdate tells kodiak to keep this branch up-to-date kodiak:disabled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-1610] Every CalendarService must send externalCalendarId
4 participants