Extend slugify function #8740
Merged
Extend slugify function #8740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
|
@AyushMainali123 is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
π¦ Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. π€ This PR introduced no changes to the JavaScript bundle! π |
sean-brydon
reviewed
May 9, 2023
2 tasks
|
@PeerRich @baileypumfleet are we actually wanting to support emojis in usernames π€ |
zomars
approved these changes
May 12, 2023
We could discuss this in a follow up |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes #7718
The slugify function appears to have limited functionality, which led to issue #7718. Additionally, I observed that the function does not trim multiple spaces in the slug.
For example:
Previously,
ayush mainaliwas updated toayush------mainali.test test test π©π½π¨π½ ζΌ’would be converted totest-test-test-----------, which is quite confusing.Now,
ayush mainaliwill be converted toayush-mainali,test test test π©π½π¨π½ ζΌ’will be converted totest-test-test-π©π½π¨π½-ζΌ’I didn't use something like:
/[^a-zA-Z0-9-\p{Emoji}]/gubecause, it couldn't properly slugify combined emoji like πͺ . It would return something likeπ¨-π©-π¦when slugified.Fixes # (7718 )
https://user-images.githubusercontent.com/49358949/236681331-41a7cd2d-7334-4291-a5ff-30ebc8bc8936.mp4
Environment: Staging(main branch) / Production
Type of change
How should this be tested?
Checklist
I have checked test suites using yarn run test (yarn test-e2e was testing against 0 test suites in my local) .
Test
Weekday tests βΊ fn: weekdayNames βΊ should return the weekday names for a given locale and formatwas failing in the production branch, so it isn't addressed in my PR.Except for that test case, all other test case has passed in the PR I submitted.