Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAL-1591: Remember form values in new booker form #8920

Merged
merged 1 commit into from May 16, 2023

Conversation

JeroenReumkens
Copy link
Contributor

What does this PR do?

Remember form values in new booker form when user navigates back and forth between timeslots and form

Fixes CAL-1591

CleanShot.2023-05-16.at.09.30.22.mp4

Environment: Staging(main branch)

Type of change

  • New feature (non-breaking change which adds functionality)

How should this be tested?

  • Switch between timeslots and form and notice the form values to stay.

@JeroenReumkens JeroenReumkens requested a review from a team May 16, 2023 07:31
@linear
Copy link

linear bot commented May 16, 2023

@vercel
Copy link

vercel bot commented May 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2023 7:37am
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2023 7:37am

@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link

Current Playwright Test Results Summary

✅ 98 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/16/2023 07:56:44am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: af36e4e

Started: 05/16/2023 07:47:08am UTC

⚠️ Flakes

📄   apps/web/playwright/booking-seats.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking with Seats -- new-booker Reschedule for booking with seats -- old-booker Should reschedule booking with seats and if everyone rescheduled it should be deleted
Retry 1Initial Attempt
0% (0) 0 / 324 runs
failed over last 7 days
75.93% (246) 246 / 324 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Member

@hariombalhara hariombalhara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome !!

@emrysal emrysal added this pull request to the merge queue May 16, 2023
Merged via the queue into main with commit 8ec178d May 16, 2023
22 checks passed
@emrysal emrysal deleted the feat/new-booker-remember-form-values branch May 16, 2023 21:04
sean-brydon pushed a commit that referenced this pull request May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants