Fixes locked workflow toggle in event type settings #8926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CarinaWolli
commented
May 16, 2023
| @@ -197,7 +197,7 @@ function EventWorkflowsTab(props: Props) { | |||
| const dataWf = data.workflows.find((wf) => wf.id === workflowOnEventType.id); | |||
| return { | |||
| ...workflowOnEventType, | |||
| readOnly: isChildrenManagedEventType && dataWf?.teamId ? true : dataWf?.readOnly ?? true, | |||
| readOnly: isChildrenManagedEventType && dataWf?.teamId ? true : dataWf?.readOnly ?? false, | |||
There was a problem hiding this comment.
if readOnly is not defined, it shouldn't be read-only
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 98 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 05/16/2023 10:17:12am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 892a3cd Started: 05/16/2023 10:06:37am UTC
|
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking with Seats -- new-booker Reschedule for booking with seats -- old-booker Should reschedule booking with seats and if everyone rescheduled it should be deleted
Retry 1 • Initial Attempt |
0% (0)0 / 334 runsfailed over last 7 days |
76.65% (256)256 / 334 runsflaked over last 7 days |
|
Booking with Seats -- old-booker Reschedule for booking with seats -- old-booker Should reschedule booking with seats and if everyone rescheduled it should be deleted
Retry 1 • Initial Attempt |
0% (0)0 / 330 runsfailed over last 7 days |
21.82% (72)72 / 330 runsflaked over last 7 days |
hariombalhara
approved these changes
May 16, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
sean-brydon
pushed a commit
that referenced
this pull request
May 18, 2023
Co-authored-by: CarinaWolli <wollencarina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes that the toggle to disable a workflow on a user event type is locked
This was the bug:
Type of change
How should this be tested?