Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: locale and time format in attendee email #8941

Merged
merged 4 commits into from May 17, 2023
Merged

Conversation

G3root
Copy link
Contributor

@G3root G3root commented May 17, 2023

What does this PR do?

fixes wrong locale and time format in attendee email.

before:

Screenshot 2023-05-17 at 13-06-14 MailDev ( 1)

after:

Screenshot 2023-05-17 at 13-05-40 MailDev ( 1)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@G3root G3root requested a review from zomars as a code owner May 17, 2023 07:37
@G3root G3root requested a review from a team May 17, 2023 07:37
@vercel
Copy link

vercel bot commented May 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2023 7:39am
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2023 7:39am

@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link

Current Playwright Test Results Summary

✅ 98 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/17/2023 07:57:58am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 1e5f784

Started: 05/17/2023 07:47:44am UTC

⚠️ Flakes

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests user -- old-booker edit first event
Retry 1Initial Attempt
0% (0) 0 / 292 runs
failed over last 7 days
1.03% (3) 3 / 292 runs
flaked over last 7 days

📄   apps/web/playwright/booking-seats.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking with Seats -- new-booker Reschedule for booking with seats -- old-booker Should reschedule booking with seats and if everyone rescheduled it should be deleted
Retry 1Initial Attempt
0% (0) 0 / 299 runs
failed over last 7 days
82.27% (246) 246 / 299 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Member

@CarinaWolli CarinaWolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CarinaWolli CarinaWolli added this pull request to the merge queue May 17, 2023
@hariombalhara
Copy link
Member

I think it fixes #8893 as well

Merged via the queue into main with commit ff74822 May 17, 2023
22 checks passed
@CarinaWolli CarinaWolli deleted the fix-locale-email branch May 17, 2023 08:46
sean-brydon pushed a commit that referenced this pull request May 18, 2023
* feat: add locale prop

* feat: add locale prop

* feat: add locale prop

* fix: time format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants