Replacement PR for closed PR #8960

[alexpgates]

What does this PR do?

This PR addresses #8928 not by shortening the width of the focus ring but by adjusting the width of the field to be consistent with other with similar settings with addOn suffixes.

Screenshot from original issue:

Previously, this text field had a w-24class that shortened up the width of the field. However, when compared to other settings (for example, the Offset Start Timers setting on the "Limits" page) it seemed inconsistent to use the w-24class.

So instead, for consistency, I just removed the w-24class which corrects the issue with the focus ring and displays the field like this:

I did consider an approach to shorten the focus ring similar to how it's done here:

However I was unable to get a good width class that aligned.
See:

Too wide.

But I do maintain that the focus ring on the shortened fields look kind of bad anyway. I'd go with the full width field!

Fixes #8928

Loom Video: https://www.loom.com/share/347251d8eaea4b108984e36e1883a772

Note that the loom video demos the corrected field first (the number of seats) but then shows the "Offset Start Timers" field on the "Advanced" page to show how the updated field is consistent with other similar fields

Environment: main production (?)

Type of change

• Bug fix (non-breaking change which fixes an issue)

How should this be tested?

I only tested by viewing the page and observing the field with and focus ring behavior

Checklist

• I haven't checked if my changes generate no new warnings
• I haven't added tests that prove my fix is effective or that my feature works
• I haven't checked if new and existing unit tests pass locally with my changes

NOTE:
This is a replacement for the previously closed PR #8960.

I initially made my changes directly to the main branch of my fork, which led to some confusion when updating my fork with the latest changes from this repository.

Apologies for the confusion! This new PR contains only the changes we need, and should be cleaner going forward. Please let me know if there's any further information or changes needed.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 19, 2023 8:12pm

[vercel]

@alexpgates is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

[github-actions]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load	% of Budget (350 KB)
/auth/setup	174.03 KB	324.94 KB	92.84% (🟢 -0.16%)

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.