Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes SMS workflow actions for premium users #8983

Merged
merged 2 commits into from May 19, 2023

Conversation

CarinaWolli
Copy link
Member

What does this PR do?

Fixes that workflows with SMS actions could not be saved when user was not on Teams plan but had premium username.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • User should not be part of a team and should have premium user name (metadata: {"isPremium":true})
  • Create a workflow
  • Add a SMS action
  • Save workflow
  • See that no error is thrown
  • Go back to the workflow and see that the SMS action is saved

@vercel
Copy link

vercel bot commented May 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2023 7:56am
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2023 7:56am

@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be a separate function, in case this is needed anywhere else (likely) - approved as is for now 👍 .

@deploysentinel
Copy link

Current Playwright Test Results Summary

✅ 98 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/19/2023 08:09:14am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 5b87bd7

Started: 05/19/2023 07:59:00am UTC

⚠️ Flakes

📄   apps/web/playwright/booking-seats.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking with Seats -- new-booker Reschedule for booking with seats -- old-booker Should reschedule booking with seats and if everyone rescheduled it should be deleted
Retry 1Initial Attempt
0% (0) 0 / 243 runs
failed over last 7 days
84.77% (206) 206 / 243 runs
flaked over last 7 days

View Detailed Build Results


@CarinaWolli CarinaWolli added this pull request to the merge queue May 19, 2023
Merged via the queue into main with commit b36043b May 19, 2023
22 checks passed
@CarinaWolli CarinaWolli deleted the fix/sms-workflow-premium-username branch May 19, 2023 08:32
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working core area: core, team members only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants