Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config support in floatingButton instruction #8986

Merged
merged 2 commits into from May 19, 2023
Merged

Add config support in floatingButton instruction #8986

merged 2 commits into from May 19, 2023

Conversation

hariombalhara
Copy link
Member

@hariombalhara hariombalhara commented May 19, 2023 •
edited

What does this PR do?

Allows providing config object to floatingButton too same as inline instruction.

Demo:
https://www.loom.com/share/a69425c8df364d4689c2614ef0439d0b

Fixes #7716

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Go to playground and click Floating Button at the bottom. You would now see prefilled booking form which happens because the config is provided for it.

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works

@hariombalhara hariombalhara requested a review from a team May 19, 2023 10:15
@linear
Copy link

linear bot commented May 19, 2023

CAL-1244 Missing prefill support with Floating Button popup Embed

Config is what actually allows certain form values to be prefilled and it's missing in floating button popup

Also, config should have prefill property to clearly signify where prefill parameters can be specified.

@vercel
Copy link

vercel bot commented May 19, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2023 7:53pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2023 7:53pm

@github-actions github-actions bot added Low priority Created by Linear-GitHub Sync ✨ feature New feature or request labels May 19, 2023
hariombalhara
hariombalhara commented May 19, 2023
View reviewed changes
packages/embeds/embed-core/src/embed.ts
@@ -466,6 +468,10 @@ class CalApi {
el.dataset.calLink = calLink;
el.dataset.calNamespace = this.cal.namespace;
el.dataset.calOrigin = calOrigin ?? "";
if (config) {
el.dataset.calConfig = JSON.stringify(config);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because floating button popup uses Element Click popup logic only, adding this data attribute is enough.

@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2023 •
edited

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/auth/setup 174.03 KB 324.94 KB 92.84% (🟢 -0.16%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@deploysentinel
Copy link

deploysentinel bot commented May 19, 2023 •
edited

Current Playwright Test Results Summary

✅ 104 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/19/2023 08:09:47pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 2d3500c

Started: 05/19/2023 08:00:58pm UTC

⚠️ Flakes

📄   apps/web/playwright/booking-seats.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking with Seats -- new-booker Reschedule for booking with seats -- old-booker Should reschedule booking with seats and if everyone rescheduled it should be deleted
Retry 1 • Initial Attempt
0% (0) 0 / 269 runs
failed over last 7 days
83.64% (225) 225 / 269 runs
flaked over last 7 days

View Detailed Build Results

alannnc
alannnc approved these changes May 19, 2023
View reviewed changes
Copy link
Contributor

@alannnc alannnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, just unsure why so many files changed in size in bundle analysis.

@PeerRich PeerRich enabled auto-merge May 19, 2023 20:00
@PeerRich PeerRich added this pull request to the merge queue May 19, 2023
Merged via the queue into main with commit 933cc73 May 19, 2023
20 checks passed
@PeerRich PeerRich deleted the hariom/cal-1244-missing-prefill-support-with-floating branch May 19, 2023 20:36
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alannnc alannnc alannnc approved these changes

Assignees
No one assigned
Labels
core area: core, team members only ✨ feature New feature or request Low priority Created by Linear-GitHub Sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CAL-1244] Missing prefill support with Floating Button popup Embed
3 participants
@hariombalhara @alannnc @PeerRich