New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reject icon color #9031
fix: reject icon color #9031
Conversation
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 114 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 05/22/2023 10:30:12am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 2f52ad8 Started: 05/22/2023 10:19:27am UTC
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Managed Event Types tests Can create managed event type
Retry 1 • Initial Attempt |
1.15% (3)3 / 260 runsfailed over last 7 days |
22.69% (59)59 / 260 runsflaked over last 7 days |
📄 apps/web/playwright/booking-seats.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Booking with Seats -- new-booker Reschedule for booking with seats -- old-booker Should reschedule booking with seats and if everyone rescheduled it should be deleted
Retry 1 • Initial Attempt |
0.37% (1)1 / 270 runfailed over last 7 days |
84.07% (227)227 / 270 runsflaked over last 7 days |
📄 apps/web/playwright/availability.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Availablity tests Date Overrides
Retry 1 • Initial Attempt |
0.71% (2)2 / 282 runsfailed over last 7 days |
3.19% (9)9 / 282 runsflaked over last 7 days |
Have you thought about adding a short line explaining why you removed the previous image and added this one? @Udit-takkar this might save a few minutes for the reviewer from opening other tabs and going back and forth. |
@@ -19,7 +11,6 @@ export const CallToActionIcon = ({ | |||
height: "1rem", | |||
width: "1rem", | |||
marginLeft: "0.5rem", | |||
...(secondary && { filter: "brightness(50%)" }), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
filter property doesn't work in emails #8890 (comment)
What does this PR do?
Fixes #8890
Environment: Staging(main branch) / Production
Type of change