Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reject icon color #9031

Merged
merged 1 commit into from May 22, 2023
Merged

fix: reject icon color #9031

merged 1 commit into from May 22, 2023

Conversation

Udit-takkar
Copy link
Contributor

What does this PR do?

Fixes #8890
Screenshot 2023-05-22 at 3 36 36 PM

Environment: Staging(main branch) / Production

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
@Udit-takkar Udit-takkar requested a review from zomars as a code owner May 22, 2023 10:07
@Udit-takkar Udit-takkar requested a review from a team May 22, 2023 10:07
@vercel
Copy link

vercel bot commented May 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2023 10:10am
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2023 10:10am

@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link

deploysentinel bot commented May 22, 2023

Current Playwright Test Results Summary

✅ 114 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/22/2023 10:30:12am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 2f52ad8

Started: 05/22/2023 10:19:27am UTC

⚠️ Flakes

📄   apps/web/playwright/managed-event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Managed Event Types tests Can create managed event type
Retry 1Initial Attempt
1.15% (3) 3 / 260 runs
failed over last 7 days
22.69% (59) 59 / 260 runs
flaked over last 7 days

📄   apps/web/playwright/booking-seats.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking with Seats -- new-booker Reschedule for booking with seats -- old-booker Should reschedule booking with seats and if everyone rescheduled it should be deleted
Retry 1Initial Attempt
0.37% (1) 1 / 270 run
failed over last 7 days
84.07% (227) 227 / 270 runs
flaked over last 7 days

📄   apps/web/playwright/availability.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Availablity tests Date Overrides
Retry 1Initial Attempt
0.71% (2) 2 / 282 runs
failed over last 7 days
3.19% (9) 9 / 282 runs
flaked over last 7 days

View Detailed Build Results


@a0m0rajab
Copy link
Contributor

Have you thought about adding a short line explaining why you removed the previous image and added this one? @Udit-takkar this might save a few minutes for the reviewer from opening other tabs and going back and forth.

@@ -19,7 +11,6 @@ export const CallToActionIcon = ({
height: "1rem",
width: "1rem",
marginLeft: "0.5rem",
...(secondary && { filter: "brightness(50%)" }),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filter property doesn't work in emails #8890 (comment)

@PeerRich PeerRich added this pull request to the merge queue May 22, 2023
Merged via the queue into main with commit def80ea May 22, 2023
22 checks passed
@PeerRich PeerRich deleted the fix/reject-icon branch May 22, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🚧 wip / in the making This is currently being worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-1696] invisible icon - email
3 participants