Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make branding hideable in the new booker #9033

Merged
merged 2 commits into from May 22, 2023
Merged

Conversation

G3root
Copy link
Contributor

@G3root G3root commented May 22, 2023

What does this PR do?

make branding hideable in the new booker component

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@G3root G3root requested a review from zomars as a code owner May 22, 2023 10:59
@G3root G3root requested a review from a team May 22, 2023 10:59
@vercel
Copy link

vercel bot commented May 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2023 11:03am
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2023 11:03am

@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/auth/setup 174.07 KB 324.97 KB 92.85% (🟢 -0.16%)
/new-booker/[user]/[type] 290.68 KB 441.58 KB 126.17% (🟡 +0.14%)
/new-booker/team/[slug]/[type] 290.68 KB 441.59 KB 126.17% (🟡 +0.14%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@deploysentinel
Copy link

deploysentinel bot commented May 22, 2023

Current Playwright Test Results Summary

✅ 114 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/22/2023 11:23:58am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: f7dbd9c

Started: 05/22/2023 11:13:18am UTC

⚠️ Flakes

📄   apps/web/playwright/booking-seats.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking with Seats -- new-booker Reschedule for booking with seats -- old-booker Should reschedule booking with seats and if everyone rescheduled it should be deleted
Retry 1Initial Attempt
0% (0) 0 / 271 runs
failed over last 7 days
84.50% (229) 229 / 271 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.test.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 2Retry 1Initial Attempt
9.87% (15) 15 / 152 runs
failed over last 7 days
30.26% (46) 46 / 152 runs
flaked over last 7 days

View Detailed Build Results


@PeerRich PeerRich added this pull request to the merge queue May 22, 2023
Merged via the queue into main with commit 4111f78 May 22, 2023
22 checks passed
@PeerRich PeerRich deleted the fix-booker-branding branch May 22, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants