fix: use the correct locale for event name in booking detail page #9055
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
G3root
changed the title
| @@ -400,7 +400,7 @@ export default function Success(props: SuccessProps) { | |||
| </> | |||
| )} | |||
| <div className="font-medium">{t("what")}</div> | |||
| <div className="col-span-2 mb-6 last:mb-0">{props.bookingInfo.title}</div> | |||
| <div className="col-span-2 mb-6 last:mb-0">{eventName}</div> | |||
There was a problem hiding this comment.
I'm not seeing a fallback behaviour, but is this the correct value to display instead, right?
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Eleven Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
Current Playwright Test Results Summary✅ 106 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 06/05/2023 08:22:56am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: f5e3e00 Started: 06/05/2023 08:20:57am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Routing Link - Reporting and CSV Download
Retry 1 • Initial Attempt |
0% (0)0 / 213 runsfailed over last 7 days |
12.68% (27)27 / 213 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
3.48% (7)7 / 201 runsfailed over last 7 days |
93.53% (188)188 / 201 runsflaked over last 7 days |
PeerRich
added
the
🧹 Improvements
|
also fixes #9292 |
What does this PR do?
previously event name saved in the db is used for booking detail page as event title, which is in the locale of the organizer. this change was introduced in #7888 to prevent "Nameless" replacing attendee while cancelling a booking. as we are now not deleting the attendees #8203 , above mentioned issue won't happen. this PR aims to fallback to
eventNamefor event title, which also fixes the wrong attendee locale issue.before:
after:
Type of change