-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Disabled pinch to zoom on mobile devices#9155 #9163
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@Gohan-18 is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
@PeerRich what is the reason for this? Its generally recommended to avoid disabling pinch to zoom as its not the best thing to do for a11y. |
@sean-brydon zooming on mobile apps looks weird and breaks the pwa experience. i dont mind keeping it, just looks weird. visit the mobile page and pinch to zoom, looks odd |
I have no objections - i think we do a pretty good job with a11y on mobile anyway. Will approve but if something comes up we should re-consider our approach to this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Gohan-18 isnt
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=0">
better?
Yeah... That's good too. Let me just modify the code. Thanks. |
Hey @PeerRich , one small help. Couldn't actually locate the file where to add the tag that works throughout app. Tried in both the theme.config.js and index.html, but doesn't seems to work. Can you please just help in locating the file. Thanks. |
|
…/cal.com into Gohan_18/pinchToZoonFix
Just updated. Thanks again for being so patience and helpful.🙏 |
What does this PR do?
Disables pinch to zoom in mobile devices
Fixes #9155 (issue)
Environment: Staging(main branch) / Production
Type of change
#- Bug fix (non-breaking change which fixes an issue)
#- Chore (refactoring code, technical debt, workflow improvements)
#- Breaking change (fix or feature that would cause existing functionality to not work as expected)
#- This change requires a documentation update
How should this be tested?
Checklist