Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disabled pinch to zoom on mobile devices#9155 #9163

Merged
merged 14 commits into from
Jun 6, 2023

Conversation

Gohan-18
Copy link
Contributor

@Gohan-18 Gohan-18 commented May 28, 2023

What does this PR do?

Disables pinch to zoom in mobile devices

Fixes #9155 (issue)

Environment: Staging(main branch) / Production

Type of change

#- Bug fix (non-breaking change which fixes an issue)
#- Chore (refactoring code, technical debt, workflow improvements)

  • New feature (non-breaking change which adds functionality)
    #- Breaking change (fix or feature that would cause existing functionality to not work as expected)
    #- This change requires a documentation update

How should this be tested?

  • Test A
  • Test B

Checklist

@vercel
Copy link

vercel bot commented May 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2023 5:36pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2023 5:36pm

@vercel
Copy link

vercel bot commented May 28, 2023

@Gohan-18 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

github-actions bot commented May 28, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@sean-brydon
Copy link
Member

@PeerRich what is the reason for this? Its generally recommended to avoid disabling pinch to zoom as its not the best thing to do for a11y.

@PeerRich PeerRich changed the title Disabled pinch to zoom on mobile devices#9155 fix: Disabled pinch to zoom on mobile devices#9155 May 30, 2023
@PeerRich
Copy link
Member

@sean-brydon zooming on mobile apps looks weird and breaks the pwa experience. i dont mind keeping it, just looks weird. visit the mobile page and pinch to zoom, looks odd

@PeerRich PeerRich added the 🧹 Improvements Improvements to existing features. Mostly UX/UI label May 30, 2023
@keithwillcode keithwillcode requested a review from a team June 1, 2023 21:57
@sean-brydon
Copy link
Member

@sean-brydon zooming on mobile apps looks weird and breaks the pwa experience. i dont mind keeping it, just looks weird. visit the mobile page and pinch to zoom, looks odd

I have no objections - i think we do a pretty good job with a11y on mobile anyway. Will approve but if something comes up we should re-consider our approach to this

Copy link
Member

@PeerRich PeerRich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gohan-18 isnt

<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=0">

better?

@Gohan-18
Copy link
Contributor Author

Gohan-18 commented Jun 2, 2023

Yeah... That's good too. Let me just modify the code. Thanks.

@Gohan-18
Copy link
Contributor Author

Gohan-18 commented Jun 2, 2023

Hey @PeerRich , one small help. Couldn't actually locate the file where to add the tag that works throughout app. Tried in both the theme.config.js and index.html, but doesn't seems to work. Can you please just help in locating the file. Thanks.

@PeerRich
Copy link
Member

PeerRich commented Jun 3, 2023

<meta> should be in _document.tsx line 51

@Gohan-18
Copy link
Contributor Author

Gohan-18 commented Jun 3, 2023

<meta> should be in _document.tsx line 51

Just updated. Thanks again for being so patience and helpful.🙏

@PeerRich PeerRich added this pull request to the merge queue Jun 6, 2023
Merged via the queue into calcom:main with commit eafd7f6 Jun 6, 2023
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 Improvements Improvements to existing features. Mostly UX/UI Low priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-1799] prevent zoom on mobile usage
4 participants