Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: validations on teams #9300

Merged
merged 2 commits into from
Jun 3, 2023
Merged

chore: validations on teams #9300

merged 2 commits into from
Jun 3, 2023

Conversation

alannnc
Copy link
Contributor

@alannnc alannnc commented Jun 3, 2023

What does this PR do?

  • Adds validations to teams

Environment: Staging(main branch)

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)

  • I haven't added tests that prove my fix is effective or that my feature works

@vercel
Copy link

vercel bot commented Jun 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2023 2:07am
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2023 2:07am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
api ⬜️ Ignored (Inspect) Jun 3, 2023 2:07am

@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Eleven Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/[user]/book 255.14 KB 406.35 KB 116.10% (🟢 -0.14%)
/apps/[slug]/[...pages] 459.38 KB 610.59 KB 174.45% (🟡 +0.26%)
/auth/setup 175.07 KB 326.28 KB 93.22% (🟡 +0.16%)
/d/[link]/book 254.79 KB 406 KB 116.00% (🟢 -0.14%)
/event-types/[type] 479.76 KB 630.97 KB 180.28% (🟡 +0.18%)
/getting-started/[[...step]] 426.45 KB 577.65 KB 165.04% (🟢 -0.22%)
/new-booker/[user]/[type] 290.34 KB 441.55 KB 126.16% (🟢 -0.15%)
/new-booker/d/[link]/[slug] 290.34 KB 441.55 KB 126.16% (🟢 -0.15%)
/new-booker/team/[slug]/[type] 290.34 KB 441.55 KB 126.16% (🟢 -0.14%)
/settings/my-account/calendars 252.68 KB 403.89 KB 115.40% (🟢 -0.24%)
/team/[slug]/book 254.79 KB 406 KB 116.00% (🟢 -0.14%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@deploysentinel
Copy link

deploysentinel bot commented Jun 3, 2023

Current Playwright Test Results Summary

✅ 90 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 06/03/2023 02:08:54am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: d3351b0

Started: 06/03/2023 02:07:20am UTC

⚠️ Flakes

📄   apps/web/playwright/login.2fa.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 1Initial Attempt
0% (0) 0 / 256 runs
failed over last 7 days
15.63% (40) 40 / 256 runs
flaked over last 7 days

View Detailed Build Results


@emrysal emrysal added this pull request to the merge queue Jun 3, 2023
Merged via the queue into main with commit dec8f8e Jun 3, 2023
29 checks passed
@emrysal emrysal deleted the chore-validations-on-teams branch June 3, 2023 11:12
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants