fix: Skeleton Padding and Width Issue #9310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@piyushgarg-dev is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
bot
added
1 points
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
|
there is still a layout shift (the icons bouncing) |
|
perfect! will merge today! |
PeerRich
reviewed
Jun 5, 2023
| @@ -667,7 +668,7 @@ const NavigationItem: React.FC<{ | |||
| {item.badge && item.badge} | |||
| </span> | |||
| ) : ( | |||
| <SkeletonText className="h-3 w-32" /> | |||
| <SkeletonText style={{ width: `${item.name.length * 10}px` }} className="h-[20px]" /> | |||
PeerRich
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the padding issue of the skeleton text in the sidebar and makes the width of the skeleton adapt to the text size.
Fixes #9309
/claim #9309
Type of change
Screenshots
Screen.Recording.2023-06-04.at.1.30.34.AM.mov