Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: background colour for show on booking page switch on event types … #9318

Merged
merged 2 commits into from
Jun 5, 2023

Conversation

ujwalkumar1995
Copy link
Contributor

What does this PR do?

This PR fixes the background colour for "show on booking page" switch on event types page.

Fixes #9316 | [CAL-1864]

Environment: Staging(main branch) / Production

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Go to event types page.
  • Go to advanced section.
  • Hover on the top of switch button to "show on booking page" for each question.
Recording.2023-06-04.161400.mp4

@vercel
Copy link

vercel bot commented Jun 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2023 10:17pm

@vercel
Copy link

vercel bot commented Jun 4, 2023

@ujwalkumar1995 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Eleven Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/[user]/book 255.79 KB 407.08 KB 116.31% (🟡 +0.14%)
/apps/[slug]/[...pages] 459.23 KB 610.52 KB 174.43% (🟢 -0.24%)
/auth/setup 174.56 KB 325.85 KB 93.10% (🟢 -0.16%)
/d/[link]/book 255.44 KB 406.73 KB 116.21% (🟡 +0.14%)
/event-types/[type] 479.23 KB 630.52 KB 180.15% (🟢 -0.19%)
/getting-started/[[...step]] 427.33 KB 578.62 KB 165.32% (🟡 +0.21%)
/new-booker/[user]/[type] 290.96 KB 442.24 KB 126.36% (🟡 +0.14%)
/new-booker/d/[link]/[slug] 290.96 KB 442.25 KB 126.36% (🟡 +0.14%)
/new-booker/team/[slug]/[type] 290.96 KB 442.25 KB 126.36% (🟡 +0.14%)
/settings/my-account/calendars 253.62 KB 404.91 KB 115.69% (🟡 +0.23%)
/team/[slug]/book 255.44 KB 406.73 KB 116.21% (🟡 +0.14%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@alannnc alannnc requested a review from sean-brydon June 5, 2023 22:13
Copy link
Contributor

@alannnc alannnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and better than before!

@alannnc alannnc enabled auto-merge June 5, 2023 22:14
@alannnc alannnc added this pull request to the merge queue Jun 5, 2023
Merged via the queue into calcom:main with commit 3a943fb Jun 5, 2023
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-1864] Dark Mode Toggles Wrong (?) Highlights
2 participants