Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: background colour for disabled select option #9320

Merged

Conversation

ujwalkumar1995
Copy link
Contributor

What does this PR do?

This PR fixes the background colour of disabled select option. The PR is specifically for issue #9313. While fixing the issue I noticed that the same issue might get replicated on other Select components which have the logic written in the same way. Any feedback is appreciated if my understanding was wrong.

Fixes #9313 | [CAL-1861]

Environment: Staging(main branch) / Production

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Create a new team.
  • Create new event type for this team
  • Select assignment as round robin
  • Select a value under the round robin hosts select dropdown.
  • Try to select a host under fixed hosts section. The disabled value will have proper colour according to the theme. Attaching video for reference.
Recording.2023-06-04.191448.mp4

@vercel
Copy link

vercel bot commented Jun 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2023 1:50pm

@vercel
Copy link

vercel bot commented Jun 4, 2023

@ujwalkumar1995 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/apps/[slug]/[...pages] 459.39 KB 610.6 KB 174.46% (🟡 +0.25%)
/auth/setup 175.07 KB 326.29 KB 93.22% (🟡 +0.17%)
/event-types/[type] 479.72 KB 630.93 KB 180.27% (🟡 +0.17%)
/getting-started/[[...step]] 426.45 KB 577.67 KB 165.05% (🟢 -0.22%)
/settings/my-account/calendars 252.69 KB 403.9 KB 115.40% (🟢 -0.23%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@PeerRich PeerRich requested review from sean-brydon and a team June 4, 2023 18:44
@PeerRich
Copy link
Member

PeerRich commented Jun 4, 2023

great change!

@PeerRich PeerRich added this pull request to the merge queue Jun 4, 2023
Copy link
Member

@sean-brydon sean-brydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipshipship

Thanks for the contribution

Merged via the queue into calcom:main with commit fd9cd1b Jun 4, 2023
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-1861] Fixed Host Drop Down Hard to See on Dark Mode
3 participants