Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace UI login with api login on e2e tests #9344

Merged
merged 5 commits into from
Jun 6, 2023

Conversation

roae
Copy link
Contributor

@roae roae commented Jun 5, 2023

What does this PR do?

Replace UI Login with a api login to avoid load the login pages this should reduce the e2e tests execution time

  • Chore (refactoring code, technical debt, workflow improvements)

@vercel
Copy link

vercel bot commented Jun 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2023 5:56pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api ⬜️ Ignored (Inspect) Jun 6, 2023 5:56pm
ui ⬜️ Ignored (Inspect) Visit Preview Jun 6, 2023 5:56pm

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link

deploysentinel bot commented Jun 5, 2023

Current Playwright Test Results Summary

✅ 107 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 06/06/2023 06:02:27pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: acdc10e

Started: 06/06/2023 06:00:23pm UTC

⚠️ Flakes

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 1Initial Attempt
4.31% (11) 11 / 255 runs
failed over last 7 days
95.69% (244) 244 / 255 runs
flaked over last 7 days
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1Initial Attempt
1.95% (5) 5 / 256 runs
failed over last 7 days
7.42% (19) 19 / 256 runs
flaked over last 7 days

📄   apps/web/playwright/login.2fa.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
2FA Tests should allow a user to disable 2FA
Retry 1Initial Attempt
0% (0) 0 / 388 runs
failed over last 7 days
17.78% (69) 69 / 388 runs
flaked over last 7 days

View Detailed Build Results


@roae roae marked this pull request as draft June 5, 2023 20:42
@roae roae requested review from zomars, hariombalhara and a team June 6, 2023 16:19
@roae roae marked this pull request as ready for review June 6, 2023 16:19
@keithwillcode keithwillcode self-requested a review June 6, 2023 17:51
Copy link
Contributor

@keithwillcode keithwillcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes to speed up these tests.

@keithwillcode keithwillcode added this pull request to the merge queue Jun 6, 2023
Merged via the queue into main with commit 17d106c Jun 6, 2023
27 checks passed
@keithwillcode keithwillcode deleted the tests/replace-ui-login-with-api-login branch June 6, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants