-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: hotfix/Embed wrong detection #9385
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 97 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 06/07/2023 08:42:34am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 15ff98b Started: 06/07/2023 08:40:34am UTC
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Managed Event Types tests Can create managed event type
Retry 1 • Initial Attempt |
1.49% (5)5 / 335 runsfailed over last 7 days |
19.40% (65)65 / 335 runsflaked over last 7 days |
📄 apps/web/playwright/login.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
user can login & logout succesfully login flow user & logout using dashboard
Retry 1 • Initial Attempt |
0.29% (1)1 / 345 runfailed over last 7 days |
8.41% (29)29 / 345 runsflaked over last 7 days |
📄 apps/web/playwright/login.2fa.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
2FA Tests should allow a user to disable 2FA
Retry 1 • Initial Attempt |
0% (0)0 / 343 runsfailed over last 7 days |
19.83% (68)68 / 343 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
7.04% (15)15 / 213 runsfailed over last 7 days |
92.96% (198)198 / 213 runsflaked over last 7 days |
What does this PR do?
Regression from #9085
Type of change
How should this be tested?
window.name='cal-embed='
in console and refresh. See that top margin goes away.Mandatory Tasks
Checklist