-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add google spam warning on booking confirmation page for gmail users ( CALCOM-9247) #9531
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
d2ba5db
to
9323542
Compare
Current Playwright Test Results Summary✅ 114 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 06/23/2023 05:13:10pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: e8562fd Started: 06/23/2023 05:10:46pm UTC
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Popup Tests should be able to reschedule
Retry 2 • Retry 1 • Initial Attempt |
22.48% (49)49 / 218 runsfailed over last 7 days |
74.77% (163)163 / 218 runsflaked over last 7 days |
📄 apps/web/playwright/booking-pages.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
pro user -- old-booker can reschedule a booking
Retry 1 • Initial Attempt |
3.25% (11)11 / 338 runsfailed over last 7 days |
2.37% (8)8 / 338 runsflaked over last 7 days |
📄 apps/web/playwright/manage-booking-questions.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Manage Booking Questions For User EventType -- old-booker Do a booking with a user added question and verify a few thing in b/w
Retry 1 • Initial Attempt |
3.21% (11)11 / 343 runsfailed over last 7 days |
0.58% (2)2 / 343 runsflaked over last 7 days |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good! Will wait for style review from @Jaibles
Co-authored-by: alannnc <alannnc@gmail.com>
Thank you for following the naming conventions! 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work!
…users ( CALCOM-9247) (calcom#9531) * feat: Add google spam warning on booking confirmation page for gmail users * Update apps/web/pages/booking/[uid].tsx Co-authored-by: alannnc <alannnc@gmail.com> --------- Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> Co-authored-by: Peer Richelsen <peeroke@gmail.com> Co-authored-by: alannnc <alannnc@gmail.com>
Fixes #9247
Demo