fix: Improved recurring event booking speed #9600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@JaideepGuntupalli is attempting to deploy a commit to the cal-staging Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
bot
added
Medium priority
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
|
Thank you for following the naming conventions! 🙏 |
alannnc
reviewed
Jun 20, 2023
Co-authored-by: alannnc <alannnc@gmail.com>
PeerRich
added
the
performance
|
hey @emrysal, @hariombalhara, @zomars, just a reminder, can you pls review the PR |
hariombalhara
approved these changes
Jul 13, 2023
fritterhoff
pushed a commit
to hm-edu/cal.com
that referenced
this pull request
Jul 25, 2023
Co-authored-by: alannnc <alannnc@gmail.com> Co-authored-by: Hariom Balhara <hariombalhara@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This pull request aims to improve the recurring booking speed by optimizing two crucial actions. The time required to perform the first action is directly proportional to the number of recurrences booked.
In the existing code, when 12 recurrences were booked, the first action took approximately 16 seconds.
However, with the changes implemented in this pull request, the same 12 recurrences can be processed in just 9 seconds.
This improvement is achieved by reducing the number of network requests from n to 1. Previously, the frontend code utilized a for loop, increasing network overhead. By streamlining the process, we significantly decrease network requests and payload size, enhancing the booking speed.
Although the network optimizations have been implemented, there is room for further improvement. One area that can be explored is reducing the number of exchanges from the database. It might be possible to create an optimized handler to enhance performance. Additionally, I couldn't find optimizations in the second action, which involves generating a booking success redirect. Further enhancements can be explored to make this action more efficient.
Fixes #9517
Type of change
How should this be tested?
Mandatory Tasks