feat: Show dark mode preview for booker layout #9664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CAL-1892 Update the layout image previews to dark mode if theme is selected (nice to have)
CleanShot 2023-06-07 at 08.35.462x.png
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thank you for following the naming conventions! 🙏 |
JeroenReumkens
commented
Jun 20, 2023
| @@ -49,6 +50,9 @@ export const EventAdvancedTab = ({ eventType, team }: Pick<EventTypeSetupProps, | |||
| const bookingFields: Prisma.JsonObject = {}; | |||
|
|
|||
| const workflows = eventType.workflows.map((workflowOnEventType) => workflowOnEventType.workflow); | |||
| const selectedThemeIsDark = | |||
| user?.theme === "dark" || | |||
| (!user?.theme && typeof document !== "undefined" && document.documentElement.classList.contains("dark")); | |||
There was a problem hiding this comment.
document is undefined on the server, that's why we also need to check for undefined.
Current Playwright Test Results Summary✅ 114 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 06/21/2023 06:57:46am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: ca56785 Started: 06/21/2023 06:55:35am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Reschedule Tests -- old-booker Attendee should be able to reschedule a booking
Retry 1 • Initial Attempt |
0% (0)0 / 281 runsfailed over last 7 days |
8.54% (24)24 / 281 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
16.06% (31)31 / 193 runsfailed over last 7 days |
80.31% (155)155 / 193 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests user -- new-booker can add multiple organizer address
Retry 1 • Initial Attempt |
0.34% (1)1 / 296 runfailed over last 7 days |
19.26% (57)57 / 296 runsflaked over last 7 days |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
…r-layout-settings
emrysal
deleted the
feat/show-correct-darkmode-preview-for-booker-layout-settings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
CAL-1892: Show booker layout dark mode preview based on theme the user selects in appearance settings.
If user selects light mode, preview for all layouts is light. Of they select dark, it's dark. And if they select system default, we show the layout that applies to the current user's system settings.
Fixes CAL-1892
Type of change
How should this be tested?