Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added organizer Cal Video recording email #9667

Merged
merged 7 commits into from
Jul 11, 2023

Conversation

Udit-takkar
Copy link
Contributor

@Udit-takkar Udit-takkar commented Jun 20, 2023

What does this PR do?

Fixes #9355

Earlier i only send download recording emails to attendees but this PR also sends the email to organizer.

Screenshot 2023-06-20 at 8 12 40 PM

Type of change

  • New feature (non-breaking change which adds functionality)

How should this be tested?

Make sure you have DAILY_API_KEY and DAILY_SCALE_PLAN="true" env variables and you are part of an active team.

  • Login as a Paid Team plan user.
  • Create a booking with cal video as location
  • open the meeting link and click on start recording and then stop recording
  • both organiser and attendees should get download recording email.

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
@vercel
Copy link

vercel bot commented Jun 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2024 3:22pm
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2024 3:22pm
cal-staging 🔄 Building (Inspect) Mar 19, 2024 3:22pm
web-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2024 3:22pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
dev ⬜️ Ignored (Inspect) Mar 19, 2024 3:22pm
ui ⬜️ Ignored (Inspect) Visit Preview Mar 19, 2024 3:22pm

@github-actions github-actions bot added Medium priority Created by Linear-GitHub Sync 🐛 bug Something isn't working labels Jun 20, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 20, 2023

Thank you for following the naming conventions! 🙏

Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
@@ -29,7 +29,7 @@ export default class AttendeeDailyVideoDownloadRecordingEmail extends BaseEmail
title: this.calEvent.title,
date: this.getFormattedDate(),
})}`,
html: renderEmail("AttendeeDailyVideoDownloadRecordingEmail", {
html: renderEmail("DailyVideoDownloadRecordingEmail", {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just changed the name here

Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
@github-actions
Copy link
Contributor

github-actions bot commented Jun 20, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link

deploysentinel bot commented Jun 20, 2023

Current Playwright Test Results Summary

✅ 68 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/11/2023 01:25:59pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 9c79719

Started: 07/11/2023 01:22:21pm UTC

⚠️ Flakes

📄   apps/web/playwright/manage-booking-questions.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Manage Booking Questions For Team EventType Do a booking with a user added question and verify a few thing in b/w
Retry 1Initial Attempt
0% (0) 0 / 9 runs
failed over last 7 days
11.11% (1) 1 / 9 run
flaked over last 7 days

📄   apps/web/playwright/booking-pages.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
pro user book an event first day in next month
Retry 1Initial Attempt
0% (0) 0 / 9 runs
failed over last 7 days
11.11% (1) 1 / 9 run
flaked over last 7 days

📄   apps/web/playwright/embed-code-generator.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Embed Code Generator Tests Event Types Page open Embed Dialog and choose element-click for First Event Type
Retry 1Initial Attempt
0% (0) 0 / 308 runs
failed over last 7 days
3.25% (10) 10 / 308 runs
flaked over last 7 days

View Detailed Build Results


@PeerRich PeerRich requested a review from a team June 22, 2023 19:42
@PeerRich PeerRich added by: cal.com core area: core, team members only and removed cal.com labels Jul 6, 2023
@PeerRich PeerRich requested a review from a team July 11, 2023 08:41
@shivamklr shivamklr self-assigned this Jul 11, 2023
@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Jul 11, 2023

🤖 Meticulous spotted visual differences in 10 of 126 screens tested: view and approve differences detected.

Last updated for commit 9c79719. This comment will update as new commits are pushed.

Copy link
Member

@CarinaWolli CarinaWolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🙌🏻

@CarinaWolli CarinaWolli merged commit 9c74285 into main Jul 11, 2023
29 of 31 checks passed
@CarinaWolli CarinaWolli deleted the fix/send-recording-to-organizer branch July 11, 2023 20:26
@ciaranha ciaranha changed the title feat: added organizer daily video recording email feat: added organizer Cal Video recording email Jul 15, 2023
fritterhoff pushed a commit to hm-edu/cal.com that referenced this pull request Jul 25, 2023
Co-authored-by: Shivam Kalra <shivamkalra98@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working core area: core, team members only Medium priority Created by Linear-GitHub Sync
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[CAL-1871] Send Download link to organiser
4 participants