Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Storybook Controls #9676

Merged

Conversation

JaideepGuntupalli
Copy link
Contributor

What does this PR do?

Added controls to as many storybooks as it was feasible. I also refactored the select and top banner stories.

Fixes #9655

https://www.loom.com/share/5ae1c5d052e4419f9274022f1ef061ae?sid=733d8ad1-a1b2-4be6-838e-6fe5aaa9eaff

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)

How should this be tested?

  • You can visit different stories and play around with controls.

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@vercel
Copy link

vercel bot commented Jun 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 23, 2023 8:58am

@vercel
Copy link

vercel bot commented Jun 21, 2023

@JaideepGuntupalli is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added Low priority Created by Linear-GitHub Sync ✨ feature New feature or request 🙋🏻‍♂️help wanted Help from the community is appreciated labels Jun 21, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 21, 2023

Thank you for following the naming conventions! 🙏

@JaideepGuntupalli JaideepGuntupalli changed the title Feat: Added Storybook Controls feat: Added Storybook Controls Jun 21, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 21, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

sean-brydon
sean-brydon previously approved these changes Jun 22, 2023
Copy link
Member

@sean-brydon sean-brydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Nothing to fault!

Great job @JaideepGuntupalli

Thanks for doing this

@JaideepGuntupalli
Copy link
Contributor Author

This is great! Nothing to fault!

Great job @JaideepGuntupalli

Thanks for doing this

Thanks for the positive feedback! I appreciate it.

@sean-brydon sean-brydon merged commit 8f5e637 into calcom:main Jun 23, 2023
25 of 28 checks passed
fritterhoff pushed a commit to hm-edu/cal.com that referenced this pull request Jul 25, 2023
Co-authored-by: sean-brydon <55134778+sean-brydon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature New feature or request 🙋🏻‍♂️help wanted Help from the community is appreciated Low priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-2004] Use Storybook controls
3 participants